2018-08-14 09:20:25

by Marcel Ziswiler

Subject: [PATCH v2] clk: tegra: probe deferral error reporting

From: Marcel Ziswiler <[email protected]>

Actually report the error code from devm_regulator_get() which may as
well just be a probe deferral.

Signed-off-by: Marcel Ziswiler <[email protected]>

---

Changes in v2:
- Silence probe deferral as discussed between Peter, Stefan and Stephen.
- Fix line over 80 characters as reported by checkpatch.

drivers/clk/tegra/clk-dfll.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
index 48ee43734e05..ebb0e1b6bf01 100644
--- a/drivers/clk/tegra/clk-dfll.c
+++ b/drivers/clk/tegra/clk-dfll.c
@@ -1609,8 +1609,12 @@ int tegra_dfll_register(struct platform_device *pdev,

td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
if (IS_ERR(td->vdd_reg)) {
- dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
- return PTR_ERR(td->vdd_reg);
+ ret = PTR_ERR(td->vdd_reg);
+ if (ret != -EPROBE_DEFER)
+ dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n",
+ ret);
+
+ return ret;
}

td->dvco_rst = devm_reset_control_get(td->dev, "dvco");
--
2.14.4

2018-08-18 12:49:44

by Stefan Agner

Subject: Re: [PATCH v2] clk: tegra: probe deferral error reporting

On 14.08.2018 11:18, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <[email protected]>
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Reviewed-by: Stefan Agner <[email protected]>

>
> ---
>
> Changes in v2:
> - Silence probe deferral as discussed between Peter, Stefan and Stephen.
> - Fix line over 80 characters as reported by checkpatch.
>
> drivers/clk/tegra/clk-dfll.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c
> index 48ee43734e05..ebb0e1b6bf01 100644
> --- a/drivers/clk/tegra/clk-dfll.c
> +++ b/drivers/clk/tegra/clk-dfll.c
> @@ -1609,8 +1609,12 @@ int tegra_dfll_register(struct platform_device *pdev,
>
> td->vdd_reg = devm_regulator_get(td->dev, "vdd-cpu");
> if (IS_ERR(td->vdd_reg)) {
> - dev_err(td->dev, "couldn't get vdd_cpu regulator\n");
> - return PTR_ERR(td->vdd_reg);
> + ret = PTR_ERR(td->vdd_reg);
> + if (ret != -EPROBE_DEFER)
> + dev_err(td->dev, "couldn't get vdd_cpu regulator: %d\n",
> + ret);
> +
> + return ret;
> }
>
> td->dvco_rst = devm_reset_control_get(td->dev, "dvco");

2018-10-16 22:32:08

by Stephen Boyd

Subject: Re: [PATCH v2] clk: tegra: probe deferral error reporting

Quoting Marcel Ziswiler (2018-08-14 02:18:05)
> From: Marcel Ziswiler <[email protected]>
>
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.
>
> Signed-off-by: Marcel Ziswiler <[email protected]>
>
> ---

Applied to clk-next