2018-08-16 11:47:44

by Tobias Klauser

[permalink] [raw]
Subject: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug

Signed-off-by: Tobias Klauser <[email protected]>
---
arch/nios2/Kconfig.debug | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
index 7a49f0d28d14..f1da8a7b17ff 100644
--- a/arch/nios2/Kconfig.debug
+++ b/arch/nios2/Kconfig.debug
@@ -3,15 +3,6 @@
config TRACE_IRQFLAGS_SUPPORT
def_bool y

-config DEBUG_STACK_USAGE
- bool "Enable stack utilization instrumentation"
- depends on DEBUG_KERNEL
- help
- Enables the display of the minimum amount of free stack which each
- task has ever had available in the sysrq-T and sysrq-P debug output.
-
- This option will slow down process creation somewhat.
-
config EARLY_PRINTK
bool "Activate early kernel debugging"
default y
--
2.18.0.130.g98da2f6b3e4a




2018-08-17 06:41:54

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

On Thu, Aug 16, 2018 at 09:05:18AM +0200, Tobias Klauser wrote:
> DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug
>
> Signed-off-by: Tobias Klauser <[email protected]>

Looks like some sort of merge error indeed:

Reviewed-by: Christoph Hellwig <[email protected]>

2018-08-20 17:25:48

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

2018-08-16 16:05 GMT+09:00 Tobias Klauser <[email protected]>:
> DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug
>
> Signed-off-by: Tobias Klauser <[email protected]>


Reviewed-by: Masahiro Yamada <[email protected]>


> ---
> arch/nios2/Kconfig.debug | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
> index 7a49f0d28d14..f1da8a7b17ff 100644
> --- a/arch/nios2/Kconfig.debug
> +++ b/arch/nios2/Kconfig.debug
> @@ -3,15 +3,6 @@
> config TRACE_IRQFLAGS_SUPPORT
> def_bool y
>
> -config DEBUG_STACK_USAGE
> - bool "Enable stack utilization instrumentation"
> - depends on DEBUG_KERNEL
> - help
> - Enables the display of the minimum amount of free stack which each
> - task has ever had available in the sysrq-T and sysrq-P debug output.
> -
> - This option will slow down process creation somewhat.
> -
> config EARLY_PRINTK
> bool "Activate early kernel debugging"
> default y
> --
> 2.18.0.130.g98da2f6b3e4a
>
>



--
Best Regards
Masahiro Yamada

2018-08-21 02:09:14

by Tan, Ley Foon

[permalink] [raw]
Subject: Re: [PATCH] nios2: kconfig: remove duplicate DEBUG_STACK_USAGE symbol defintions

On Tue, 2018-08-21 at 01:15 +0900, Masahiro Yamada wrote:
> 2018-08-16 16:05 GMT+09:00 Tobias Klauser <[email protected]>:
> >
> > DEBUG_STACK_USAGE is already defined in lib/Kconfig.debug
> >
> > Signed-off-by: Tobias Klauser <[email protected]>
>
> Reviewed-by: Masahiro Yamada <[email protected]>
>
Acked-by: Ley Foon Tan <[email protected]>

>
> >
> > ---
> >  arch/nios2/Kconfig.debug | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
> > index 7a49f0d28d14..f1da8a7b17ff 100644
> > --- a/arch/nios2/Kconfig.debug
> > +++ b/arch/nios2/Kconfig.debug
> > @@ -3,15 +3,6 @@
> >  config TRACE_IRQFLAGS_SUPPORT
> >         def_bool y
> >
> > -config DEBUG_STACK_USAGE
> > -       bool "Enable stack utilization instrumentation"
> > -       depends on DEBUG_KERNEL
> > -       help
> > -         Enables the display of the minimum amount of free stack
> > which each
> > -         task has ever had available in the sysrq-T and sysrq-P
> > debug output.
> > -
> > -         This option will slow down process creation somewhat.
> > -
> >  config EARLY_PRINTK
> >         bool "Activate early kernel debugging"
> >         default y
> > --
> > 2.18.0.130.g98da2f6b3e4a
> >
> >
>
>
> --
> Best Regards
> Masahiro Yamada
>
> ________________________________
>
> Confidentiality Notice.
> This message may contain information that is confidential or
> otherwise protected from disclosure. If you are not the intended
> recipient, you are hereby notified that any use, disclosure,
> dissemination, distribution, or copying of this message, or any
> attachments, is strictly prohibited. If you have received this
> message in error, please advise the sender by reply e-mail, and
> delete the message and any attachments. Thank you.