2018-08-16 16:28:20

by Esben Haabendal

[permalink] [raw]
Subject: [PATCH v4 3/3] arm: dts: ls1021a: Enable I2C DMA support

From: Esben Haabendal <[email protected]>

Gives substantial performance improvement for transfers larger than 16
bytes (DMA_THRESHOLD). Smaller transfers are unaffected.

Signed-off-by: Esben Haabendal <[email protected]>
---
arch/arm/boot/dts/ls1021a.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index c55d479971cc..1e5640701c65 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -363,6 +363,8 @@
interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 39>, <&edma0 1 38>;
status = "disabled";
};

@@ -374,6 +376,8 @@
interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 37>, <&edma0 1 36>;
status = "disabled";
};

@@ -385,6 +389,8 @@
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
clock-names = "i2c";
clocks = <&clockgen 4 1>;
+ dma-names = "tx", "rx";
+ dmas = <&edma0 1 35>, <&edma0 1 34>;
status = "disabled";
};

--
2.18.0



2018-08-16 18:46:03

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] arm: dts: ls1021a: Enable I2C DMA support

On Thu, Aug 16, 2018 at 10:43:14AM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <[email protected]>
>
> Gives substantial performance improvement for transfers larger than 16
> bytes (DMA_THRESHOLD). Smaller transfers are unaffected.
>
> Signed-off-by: Esben Haabendal <[email protected]>

Looks reasonable to me.

Acked-by: Uwe Kleine-K?nig <[email protected]>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2018-08-20 09:17:27

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] arm: dts: ls1021a: Enable I2C DMA support

On Thu, Aug 16, 2018 at 10:43:14AM +0200, Esben Haabendal wrote:
> From: Esben Haabendal <[email protected]>
>
> Gives substantial performance improvement for transfers larger than 16
> bytes (DMA_THRESHOLD). Smaller transfers are unaffected.
>
> Signed-off-by: Esben Haabendal <[email protected]>

This needs to go via arm-soc. The two other patches will be in v4.19
with my pull request later this week.


Attachments:
(No filename) (411.00 B)
signature.asc (849.00 B)
Download all attachments

2018-08-20 09:25:43

by Esben Haabendal

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] arm: dts: ls1021a: Enable I2C DMA support

Wolfram Sang <[email protected]> writes:

> On Thu, Aug 16, 2018 at 10:43:14AM +0200, Esben Haabendal wrote:
>> From: Esben Haabendal <[email protected]>
>>
>> Gives substantial performance improvement for transfers larger than 16
>> bytes (DMA_THRESHOLD). Smaller transfers are unaffected.
>>
>> Signed-off-by: Esben Haabendal <[email protected]>
>
> This needs to go via arm-soc. The two other patches will be in v4.19
> with my pull request later this week.

Ok, do I need to send to additional list(s)?
[email protected]?

/Esben

2018-08-20 11:16:11

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] arm: dts: ls1021a: Enable I2C DMA support


> Ok, do I need to send to additional list(s)?
> [email protected]?

I'd say resend this patch after rc1 is out and the other 2 patches are
upstream.


Attachments:
(No filename) (178.00 B)
signature.asc (849.00 B)
Download all attachments