2018-08-16 19:50:17

by Steven Rostedt

[permalink] [raw]
Subject: [PATCH] tracing: Add SPDX License format to bpf_trace.c

[ Alexei and/or Daniel, I'm adding SPDX headers to the tracing
directory. Can you ack this patch? Thanks ]

From: "Steven Rostedt (VMware)" <[email protected]>

Add the SPDX License header to ease license compliance management.

Cc: Alexei Starovoitov <[email protected]>
Cc: Daniel Borkmann <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
---
kernel/trace/bpf_trace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index 0ae6829804bc..1d11a6e6f2d0 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -1,9 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2011-2015 PLUMgrid, http://plumgrid.com
* Copyright (c) 2016 Facebook
*
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of version 2 of the GNU General Public
- * License as published by the Free Software Foundation.
*/
#include <linux/kernel.h>
#include <linux/types.h>
--
2.13.6



2018-08-16 22:22:48

by Alexei Starovoitov

[permalink] [raw]
Subject: Re: [PATCH] tracing: Add SPDX License format to bpf_trace.c

On Thu, Aug 16, 2018 at 03:48:17PM -0400, Steven Rostedt wrote:
> [ Alexei and/or Daniel, I'm adding SPDX headers to the tracing
> directory. Can you ack this patch? Thanks ]
>
> From: "Steven Rostedt (VMware)" <[email protected]>
>
> Add the SPDX License header to ease license compliance management.
>
> Cc: Alexei Starovoitov <[email protected]>

ohh. did you get a reply from that address? ;)

> Cc: Daniel Borkmann <[email protected]>
> Signed-off-by: Steven Rostedt (VMware) <[email protected]>

Acked-by: Alexei Starovoitov <[email protected]>


2018-08-16 22:36:49

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH] tracing: Add SPDX License format to bpf_trace.c

On 08/17/2018 12:20 AM, Alexei Starovoitov wrote:
> On Thu, Aug 16, 2018 at 03:48:17PM -0400, Steven Rostedt wrote:
>> [ Alexei and/or Daniel, I'm adding SPDX headers to the tracing
>> directory. Can you ack this patch? Thanks ]
>>
>> From: "Steven Rostedt (VMware)" <[email protected]>
>>
>> Add the SPDX License header to ease license compliance management.
>>
>> Cc: Alexei Starovoitov <[email protected]>
>
> ohh. did you get a reply from that address? ;)
>
>> Cc: Daniel Borkmann <[email protected]>
>> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
>
> Acked-by: Alexei Starovoitov <[email protected]>

Also from my side:

Acked-by: Daniel Borkmann <[email protected]>

+// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2011-2015 PLUMgrid, http://plumgrid.com
* Copyright (c) 2016 Facebook
*

You probably also want to remove that single '*' line as well in your patch.

- * This program is free software; you can redistribute it and/or
- * modify it under the terms of version 2 of the GNU General Public
- * License as published by the Free Software Foundation.
*/

Thanks,
Daniel

2018-08-16 23:08:42

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing: Add SPDX License format to bpf_trace.c

On Thu, 16 Aug 2018 15:20:58 -0700
Alexei Starovoitov <[email protected]> wrote:

> On Thu, Aug 16, 2018 at 03:48:17PM -0400, Steven Rostedt wrote:
> > [ Alexei and/or Daniel, I'm adding SPDX headers to the tracing
> > directory. Can you ack this patch? Thanks ]
> >
> > From: "Steven Rostedt (VMware)" <[email protected]>
> >
> > Add the SPDX License header to ease license compliance management.
> >
> > Cc: Alexei Starovoitov <[email protected]>
>
> ohh. did you get a reply from that address? ;)

Funny, I didn't even send it to that address. I used what I had in my
address book to do this email. I'm not even sure where I got that. I
think I was looking at one of the old commits of that file and cut and
pasted the address there.

>
> > Cc: Daniel Borkmann <[email protected]>
> > Signed-off-by: Steven Rostedt (VMware) <[email protected]>
>
> Acked-by: Alexei Starovoitov <[email protected]>

Thanks! (I'll update the change log with this email)

-- Steve

2018-08-16 23:09:32

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing: Add SPDX License format to bpf_trace.c

On Fri, 17 Aug 2018 00:34:21 +0200
Daniel Borkmann <[email protected]> wrote:

> On 08/17/2018 12:20 AM, Alexei Starovoitov wrote:
> > On Thu, Aug 16, 2018 at 03:48:17PM -0400, Steven Rostedt wrote:
> >> [ Alexei and/or Daniel, I'm adding SPDX headers to the tracing
> >> directory. Can you ack this patch? Thanks ]
> >>
> >> From: "Steven Rostedt (VMware)" <[email protected]>
> >>
> >> Add the SPDX License header to ease license compliance management.
> >>
> >> Cc: Alexei Starovoitov <[email protected]>
> >
> > ohh. did you get a reply from that address? ;)
> >
> >> Cc: Daniel Borkmann <[email protected]>
> >> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
> >
> > Acked-by: Alexei Starovoitov <[email protected]>
>
> Also from my side:
>
> Acked-by: Daniel Borkmann <[email protected]>

Thanks!

>
> +// SPDX-License-Identifier: GPL-2.0
> /* Copyright (c) 2011-2015 PLUMgrid, http://plumgrid.com
> * Copyright (c) 2016 Facebook
> *
>
> You probably also want to remove that single '*' line as well in your patch.

Done.

-- Steve

>
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of version 2 of the GNU General Public
> - * License as published by the Free Software Foundation.
> */
>
> Thanks,
> Daniel