2018-08-27 16:45:46

by Ivan Mikhaylov

Subject: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions

Signed-off-by: Ivan Mikhaylov <[email protected]>
---
drivers/net/ethernet/ibm/emac/emac.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/ibm/emac/emac.h b/drivers/net/ethernet/ibm/emac/emac.h
index e2f80cc..f541660 100644
--- a/drivers/net/ethernet/ibm/emac/emac.h
+++ b/drivers/net/ethernet/ibm/emac/emac.h
@@ -229,7 +229,6 @@ struct emac_regs {
#define EMAC_STACR_PHYD_SHIFT 16
#define EMAC_STACR_OC 0x00008000
#define EMAC_STACR_PHYE 0x00004000
-#define EMAC_STACR_STAC_MASK 0x00003000
#define EMAC_STACR_STAC_READ 0x00001000
#define EMAC_STACR_STAC_WRITE 0x00000800
#define EMAC_STACR_OPBC_MASK 0x00000C00
@@ -245,14 +244,8 @@ struct emac_regs {
#define EMAC_STACR_PCDA_MASK 0x1f
#define EMAC_STACR_PCDA_SHIFT 5
#define EMAC_STACR_PRA_MASK 0x1f
-#define EMACX_STACR_STAC_MASK 0x00003800
#define EMACX_STACR_STAC_READ 0x00001000
#define EMACX_STACR_STAC_WRITE 0x00000800
-#define EMACX_STACR_STAC_IND_ADDR 0x00002000
-#define EMACX_STACR_STAC_IND_READ 0x00003800
-#define EMACX_STACR_STAC_IND_READINC 0x00003000
-#define EMACX_STACR_STAC_IND_WRITE 0x00002800
-

/* EMACx_TRTR */
#define EMAC_TRTR_SHIFT_EMAC4 24
--
1.7.1

2018-08-30 01:11:30

by David Miller

Subject: Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions

From: Ivan Mikhaylov <[email protected]>
Date: Mon, 27 Aug 2018 19:43:36 +0300

> Signed-off-by: Ivan Mikhaylov <[email protected]>

Please do not delete these, they could be useful for other
developers and people reading this driver.

2018-08-31 11:25:42

by Ivan Mikhaylov

Subject: Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions

>Please do not delete these, they could be useful for other
>developers and people reading this driver.
Hmm, that's possible, need I resubmit first patch without this one?

2018-08-31 16:42:05

by David Miller

Subject: Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions

From: Ivan Mikhaylov <[email protected]>
Date: Fri, 31 Aug 2018 14:23:45 +0300

>>Please do not delete these, they could be useful for other
>>developers and people reading this driver.
> Hmm, that's possible, need I resubmit first patch without this one?

Yes.