2018-08-29 07:38:23

by Yinbo Zhu

[permalink] [raw]
Subject: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

This patch is to add description of 'configure-gfladj' to binding
so that configuring devicetree

Signed-off-by: Yinbo Zhu <[email protected]>
---
Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 3e4c38b..40c6568 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -101,6 +101,7 @@ Optional properties:
When just one value, which means INCRX burst mode enabled. When
more than one value, which means undefined length INCR burst type
enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
+ - configure-gfladj: determine whether frame length adjustment is required or not.

- in addition all properties from usb-xhci.txt from the current directory are
supported as well
--
1.7.1



2018-09-03 01:22:20

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
>
> Signed-off-by: Yinbo Zhu <[email protected]>

Ah, okay. You just started documenting the binding. So please send me
dts patch only after the corresponding bindings and driver code are
accepted.

Shawn

> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
> When just one value, which means INCRX burst mode enabled. When
> more than one value, which means undefined length INCR burst type
> enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>
> - in addition all properties from usb-xhci.txt from the current directory are
> supported as well
> --
> 1.7.1
>

2018-09-05 20:12:35

by Leo Li

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

On Wed, Aug 29, 2018 at 2:38 AM Yinbo Zhu <[email protected]> wrote:
>
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
>
> Signed-off-by: Yinbo Zhu <[email protected]>

This patch should be sent to the DWC3 driver maintainer to review and
probably merged through usb tree. You shouldn't use the arm64: dts:
prefix for this patch either.

> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
> When just one value, which means INCRX burst mode enabled. When
> more than one value, which means undefined length INCR burst type
> enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>
> - in addition all properties from usb-xhci.txt from the current directory are
> supported as well
> --
> 1.7.1
>

2018-09-10 05:47:44

by Felipe Balbi

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

Yinbo Zhu <[email protected]> writes:

> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

commit log looks incomplete.

--
balbi


Attachments:
signature.asc (847.00 B)

2018-09-25 16:49:28

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

Not a complete sentence.

The subject should be: "dt-bindings: usb: ..."
>
> Signed-off-by: Yinbo Zhu <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/dwc3.txt | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
> When just one value, which means INCRX burst mode enabled. When
> more than one value, which means undefined length INCR burst type
> enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.

Needs a vendor prefix.

What's the type? bool?

What determines if this is needed. If fixed for an SoC or IP version,
then the compatible string should imply this.

Rob