LinuxLists.cc - [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check

2018-08-29 20:05:06

Subject: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check

Checking the child node names is pointless as the DT node name can
never be NULL, so remove it.

Cc: Shawn Guo <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
drivers/bus/imx-weim.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 6a94aa6a22c2..d84996a4528e 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -156,9 +156,6 @@ static int __init weim_parse_dt(struct platform_device *pdev,
}

for_each_available_child_of_node(pdev->dev.of_node, child) {
- if (!child->name)
- continue;
-
ret = weim_timing_setup(child, base, devtype);
if (ret)
dev_warn(&pdev->dev, "%pOF set timing failed.\n",
--
2.17.1

2018-09-03 02:19:44

by Shawn Guo

[permalink] [raw]

Subject: Re: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check

On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can
> never be NULL, so remove it.
>
> Cc: Shawn Guo <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>

Applied, thanks.

2018-09-03 04:24:06

by Shawn Guo

[permalink] [raw]