2018-09-06 02:12:23

by Masanari Iida

Subject: [PATCH] drm/amdgpu: Fix wornings while make xmldocs

This patch fixes following wornings.

./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3011:
warning: Excess function parameter 'dev' description
in 'amdgpu_vm_get_task_info'

./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012:
warning: Function parameter or member 'adev' not
described in 'amdgpu_vm_get_task_info'

./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012:
warning: Excess function parameter 'dev' description
in 'amdgpu_vm_get_task_info'

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index b17771dd5ce7..861718e2be7a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -3002,7 +3002,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
/**
* amdgpu_vm_get_task_info - Extracts task info for a PASID.
*
- * @dev: drm device pointer
+ * @adev: drm device pointer
* @pasid: PASID identifier for VM
* @task_info: task_info to fill.
*/
--
2.19.0.rc2

2018-09-07 16:49:30

by Michel Dänzer

Subject: Re: [PATCH] drm/amdgpu: Fix wornings while make xmldocs

Hi Iida-san,


On 2018-09-06 4:10 a.m., Masanari Iida wrote:
> This patch fixes following wornings.
>
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3011:
> warning: Excess function parameter 'dev' description
> in 'amdgpu_vm_get_task_info'
>
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012:
> warning: Function parameter or member 'adev' not
> described in 'amdgpu_vm_get_task_info'
>
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012:
> warning: Excess function parameter 'dev' description
> in 'amdgpu_vm_get_task_info'
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index b17771dd5ce7..861718e2be7a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -3002,7 +3002,7 @@ int amdgpu_vm_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
> /**
> * amdgpu_vm_get_task_info - Extracts task info for a PASID.
> *
> - * @dev: drm device pointer
> + * @adev: drm device pointer
> * @pasid: PASID identifier for VM
> * @task_info: task_info to fill.
> */
>

Queued in the amdgpu tree (with fixed spelling of "warnings"), thanks!


--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer