2018-09-04 14:22:07

by Andrew Davis

Subject: [PATCH v2 1/2] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name use this here.

Signed-off-by: Andrew F. Davis <[email protected]>
---

Changes from v1:
- Remove "fix" from commit message

arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 7fff3717cf7c..a0f5cfda0055 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -384,7 +384,7 @@
AVDD-supply = <&reg_3p3v>;
IOVDD-supply = <&reg_3p3v>;
DVDD-supply = <&vgen4_reg>;
- gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
};

accel@1c {
@@ -572,7 +572,7 @@
AVDD-supply = <&reg_3p3v>;
IOVDD-supply = <&reg_3p3v>;
DVDD-supply = <&vgen4_reg>;
- gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
};

touchscreen@20 {
--
2.18.0

2018-09-04 14:22:07

by Andrew Davis

Subject: [PATCH v2 2/2] ARM: dts: imx: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset
is "reset-gpios", the driver now accepts this name use this here.

Signed-off-by: Andrew F. Davis <[email protected]>
---

Changes from v1:
- Remove "fix" from commit message

arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
index 368132274a91..ddabab168a8a 100644
--- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi
@@ -310,7 +310,7 @@
tlv320aic3105: codec@18 {
compatible = "ti,tlv320aic3x";
reg = <0x18>;
- gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+ reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
clocks = <&clks IMX6QDL_CLK_CKO>;
ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
/* Regulators */
--
2.18.0

2018-09-10 03:22:36

by Shawn Guo

Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

On Tue, Sep 04, 2018 at 09:20:17AM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", the driver now accepts this name use this here.
>
> Signed-off-by: Andrew F. Davis <[email protected]>
> ---
>
> Changes from v1:
> - Remove "fix" from commit message
>
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
> AVDD-supply = <&reg_3p3v>;
> IOVDD-supply = <&reg_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;

Is it intended to change the polarity?

Shawn

> };
>
> accel@1c {
> @@ -572,7 +572,7 @@
> AVDD-supply = <&reg_3p3v>;
> IOVDD-supply = <&reg_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> };
>
> touchscreen@20 {
> --
> 2.18.0
>