2018-09-11 13:43:50

by Gerd Hoffmann

Subject: [PATCH v2 12/13] udmabuf: use sizeof(variable) instead of sizeof(type)

Reported-by: Laurent Pinchart <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
---
drivers/dma-buf/udmabuf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 7a4fd2194d..92af9b5300 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -128,7 +128,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
int seals, ret = -EINVAL;
u32 i, flags;

- ubuf = kzalloc(sizeof(struct udmabuf), GFP_KERNEL);
+ ubuf = kzalloc(sizeof(*ubuf), GFP_KERNEL);
if (!ubuf)
return -ENOMEM;

@@ -142,7 +142,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
if (ubuf->pagecount > pglimit)
goto err;
}
- ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(struct page *),
+ ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(*ubuf->pages),
GFP_KERNEL);
if (!ubuf->pages) {
ret = -ENOMEM;
@@ -211,7 +211,7 @@ static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
struct udmabuf_create_item list;

if (copy_from_user(&create, (void __user *)arg,
- sizeof(struct udmabuf_create)))
+ sizeof(create)))
return -EFAULT;

head.flags = create.flags;
--
2.9.3

2018-09-11 15:08:14

by Laurent Pinchart

Subject: Re: [PATCH v2 12/13] udmabuf: use sizeof(variable) instead of sizeof(type)

Hi Gerd,

Thank you for the patch.

On Tuesday, 11 September 2018 16:42:15 EEST Gerd Hoffmann wrote:
> Reported-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Gerd Hoffmann <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/dma-buf/udmabuf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index 7a4fd2194d..92af9b5300 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -128,7 +128,7 @@ static long udmabuf_create(const struct
> udmabuf_create_list *head, int seals, ret = -EINVAL;
> u32 i, flags;
>
> - ubuf = kzalloc(sizeof(struct udmabuf), GFP_KERNEL);
> + ubuf = kzalloc(sizeof(*ubuf), GFP_KERNEL);
> if (!ubuf)
> return -ENOMEM;
>
> @@ -142,7 +142,7 @@ static long udmabuf_create(const struct
> udmabuf_create_list *head, if (ubuf->pagecount > pglimit)
> goto err;
> }
> - ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(struct page *),
> + ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(*ubuf->pages),
> GFP_KERNEL);
> if (!ubuf->pages) {
> ret = -ENOMEM;
> @@ -211,7 +211,7 @@ static long udmabuf_ioctl_create(struct file *filp,
> unsigned long arg) struct udmabuf_create_item list;
>
> if (copy_from_user(&create, (void __user *)arg,
> - sizeof(struct udmabuf_create)))
> + sizeof(create)))
> return -EFAULT;
>
> head.flags = create.flags;

--
Regards,

Laurent Pinchart