2018-09-12 02:39:32

by Joshua Abraham

Subject: [PATCH] drivers: pci: remove set but unused variable

This patch removes a set but unused variable in quirks.c.

Fixes warning:
variable ‘mmio_sys_info’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Joshua Abraham <[email protected]>
---
drivers/pci/quirks.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index ef7143a274e0..690a3b71aa1f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4993,7 +4993,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
void __iomem *mmio;
struct ntb_info_regs __iomem *mmio_ntb;
struct ntb_ctrl_regs __iomem *mmio_ctrl;
- struct sys_info_regs __iomem *mmio_sys_info;
u64 partition_map;
u8 partition;
int pp;
@@ -5014,7 +5013,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)

mmio_ntb = mmio + SWITCHTEC_GAS_NTB_OFFSET;
mmio_ctrl = (void __iomem *) mmio_ntb + SWITCHTEC_NTB_REG_CTRL_OFFSET;
- mmio_sys_info = mmio + SWITCHTEC_GAS_SYS_INFO_OFFSET;

partition = ioread8(&mmio_ntb->partition_id);

--
2.17.1

2018-09-12 12:12:03

by Bjorn Helgaas

Subject: Re: [PATCH] drivers: pci: remove set but unused variable

On Tue, Sep 11, 2018 at 04:39:08PM -1000, Joshua Abraham wrote:
> This patch removes a set but unused variable in quirks.c.
>
> Fixes warning:
> variable ‘mmio_sys_info’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <[email protected]>

Applied to pci/misc for v4.20, thanks!

> ---
> drivers/pci/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index ef7143a274e0..690a3b71aa1f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4993,7 +4993,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
> void __iomem *mmio;
> struct ntb_info_regs __iomem *mmio_ntb;
> struct ntb_ctrl_regs __iomem *mmio_ctrl;
> - struct sys_info_regs __iomem *mmio_sys_info;
> u64 partition_map;
> u8 partition;
> int pp;
> @@ -5014,7 +5013,6 @@ static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
>
> mmio_ntb = mmio + SWITCHTEC_GAS_NTB_OFFSET;
> mmio_ctrl = (void __iomem *) mmio_ntb + SWITCHTEC_NTB_REG_CTRL_OFFSET;
> - mmio_sys_info = mmio + SWITCHTEC_GAS_SYS_INFO_OFFSET;
>
> partition = ioread8(&mmio_ntb->partition_id);
>
> --
> 2.17.1
>