From: Bjorn Helgaas <[email protected]>
The original PCI error recovery functionality was for the powerpc-specific
IBM EEH feature. PCIe subsequently added some similar features, including
AER and DPC, that can be used on any architecture.
We want the generic PCI core error handling support to work with all of
these features. Driver error recovery callbacks should be independent of
which feature the platform provides.
Add the generic PCI core error recovery files to the powerpc EEH
MAINTAINERS entry so the powerpc folks will be copied on changes to the
generic PCI error handling strategy.
Signed-off-by: Bjorn Helgaas <[email protected]>
---
MAINTAINERS | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 7e10ba65bfe4..d6699597fd89 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11202,6 +11202,10 @@ PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
M: Russell Currey <[email protected]>
L: [email protected]
S: Supported
+F: Documentation/PCI/pci-error-recovery.txt
+F: drivers/pci/pcie/aer.c
+F: drivers/pci/pcie/dpc.c
+F: drivers/pci/pcie/err.c
F: Documentation/powerpc/eeh-pci-error-recovery.txt
F: arch/powerpc/kernel/eeh*.c
F: arch/powerpc/platforms/*/eeh*.c
On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The original PCI error recovery functionality was for the powerpc-specific
> IBM EEH feature. PCIe subsequently added some similar features, including
> AER and DPC, that can be used on any architecture.
>
> We want the generic PCI core error handling support to work with all of
> these features. Driver error recovery callbacks should be independent of
> which feature the platform provides.
>
> Add the generic PCI core error recovery files to the powerpc EEH
> MAINTAINERS entry so the powerpc folks will be copied on changes to the
> generic PCI error handling strategy.
I really want to make sure the powerpc folks are plugged into any PCI core
error handling discussions. Please let me know if there's a better way
than this patch, or if there are other people who should be added.
> Signed-off-by: Bjorn Helgaas <[email protected]>
> ---
> MAINTAINERS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7e10ba65bfe4..d6699597fd89 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11202,6 +11202,10 @@ PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> M: Russell Currey <[email protected]>
> L: [email protected]
> S: Supported
> +F: Documentation/PCI/pci-error-recovery.txt
> +F: drivers/pci/pcie/aer.c
> +F: drivers/pci/pcie/dpc.c
> +F: drivers/pci/pcie/err.c
> F: Documentation/powerpc/eeh-pci-error-recovery.txt
> F: arch/powerpc/kernel/eeh*.c
> F: arch/powerpc/platforms/*/eeh*.c
>
On Wed, 2018-09-12 at 11:58 -0500, Bjorn Helgaas wrote:
> On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > The original PCI error recovery functionality was for the powerpc-specific
> > IBM EEH feature. PCIe subsequently added some similar features, including
> > AER and DPC, that can be used on any architecture.
> >
> > We want the generic PCI core error handling support to work with all of
> > these features. Driver error recovery callbacks should be independent of
> > which feature the platform provides.
> >
> > Add the generic PCI core error recovery files to the powerpc EEH
> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > generic PCI error handling strategy.
>
> I really want to make sure the powerpc folks are plugged into any PCI core
> error handling discussions. Please let me know if there's a better way
> than this patch, or if there are other people who should be added.
I think this patch is definitely a good idea.
Alongside this (whether you want to include it in your patch or not, Bjorn),
Sam Bobroff should replace myself as maintainer. He's been very active in fixing,
reworking and reviewing in EEH land and will probably do a better job of keeping
his finger on the pulse of the generic PCI error handling code than I did.
- Russell
>
> > Signed-off-by: Bjorn Helgaas <[email protected]>
> > ---
> > MAINTAINERS | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 7e10ba65bfe4..d6699597fd89 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11202,6 +11202,10 @@ PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> > M: Russell Currey <[email protected]>
> > L: [email protected]
> > S: Supported
> > +F: Documentation/PCI/pci-error-recovery.txt
> > +F: drivers/pci/pcie/aer.c
> > +F: drivers/pci/pcie/dpc.c
> > +F: drivers/pci/pcie/err.c
> > F: Documentation/powerpc/eeh-pci-error-recovery.txt
> > F: arch/powerpc/kernel/eeh*.c
> > F: arch/powerpc/platforms/*/eeh*.c
> >
On Wed, 2018-09-12 at 11:58 -0500, Bjorn Helgaas wrote:
> > Add the generic PCI core error recovery files to the powerpc EEH
> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > generic PCI error handling strategy.
>
> I really want to make sure the powerpc folks are plugged into any PCI core
> error handling discussions. Please let me know if there's a better way
> than this patch, or if there are other people who should be added.
Sounds good. Oliver, you want to be looped in as well ?
Cheers,
Ben.
On Thu, Sep 13, 2018 at 6:35 PM, Benjamin Herrenschmidt
<[email protected]> wrote:
> On Wed, 2018-09-12 at 11:58 -0500, Bjorn Helgaas wrote:
>> > Add the generic PCI core error recovery files to the powerpc EEH
>> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
>> > generic PCI error handling strategy.
>>
>> I really want to make sure the powerpc folks are plugged into any PCI core
>> error handling discussions. Please let me know if there's a better way
>> than this patch, or if there are other people who should be added.
>
> Sounds good. Oliver, you want to be looped in as well ?
Sure, putting all of EEH on Sam is probably not a nice thing to do.
> Cheers,
> Ben.
>
>
On Thu, Sep 13, 2018 at 12:26:55PM +1000, Russell Currey wrote:
> On Wed, 2018-09-12 at 11:58 -0500, Bjorn Helgaas wrote:
> > On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <[email protected]>
> > >
> > > The original PCI error recovery functionality was for the powerpc-specific
> > > IBM EEH feature. PCIe subsequently added some similar features, including
> > > AER and DPC, that can be used on any architecture.
> > >
> > > We want the generic PCI core error handling support to work with all of
> > > these features. Driver error recovery callbacks should be independent of
> > > which feature the platform provides.
> > >
> > > Add the generic PCI core error recovery files to the powerpc EEH
> > > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > > generic PCI error handling strategy.
> >
> > I really want to make sure the powerpc folks are plugged into any PCI core
> > error handling discussions. Please let me know if there's a better way
> > than this patch, or if there are other people who should be added.
>
> I think this patch is definitely a good idea.
>
> Alongside this (whether you want to include it in your patch or not, Bjorn),
> Sam Bobroff should replace myself as maintainer. He's been very active in fixing,
> reworking and reviewing in EEH land and will probably do a better job of keeping
> his finger on the pulse of the generic PCI error handling code than I did.
>
> - Russell
That's fine with me. You can add me or let me know if I should send a
patch.
Sam.
>
> >
> > > Signed-off-by: Bjorn Helgaas <[email protected]>
> > > ---
> > > MAINTAINERS | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 7e10ba65bfe4..d6699597fd89 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11202,6 +11202,10 @@ PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> > > M: Russell Currey <[email protected]>
> > > L: [email protected]
> > > S: Supported
> > > +F: Documentation/PCI/pci-error-recovery.txt
> > > +F: drivers/pci/pcie/aer.c
> > > +F: drivers/pci/pcie/dpc.c
> > > +F: drivers/pci/pcie/err.c
> > > F: Documentation/powerpc/eeh-pci-error-recovery.txt
> > > F: arch/powerpc/kernel/eeh*.c
> > > F: arch/powerpc/platforms/*/eeh*.c
> > >
>
On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The original PCI error recovery functionality was for the powerpc-specific
> IBM EEH feature. PCIe subsequently added some similar features, including
> AER and DPC, that can be used on any architecture.
>
> We want the generic PCI core error handling support to work with all of
> these features. Driver error recovery callbacks should be independent of
> which feature the platform provides.
>
> Add the generic PCI core error recovery files to the powerpc EEH
> MAINTAINERS entry so the powerpc folks will be copied on changes to the
> generic PCI error handling strategy.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
I applied the following to for-linus for v4.19. Russell, if you want
to be removed, let me know and I'll do that.
commit 3fed0e04026c
Author: Bjorn Helgaas <[email protected]>
Date: Wed Sep 12 11:55:26 2018 -0500
MAINTAINERS: Update PPC contacts for PCI core error handling
The original PCI error recovery functionality was for the powerpc-specific
IBM EEH feature. PCIe subsequently added some similar features, including
AER and DPC, that can be used on any architecture.
We want the generic PCI core error handling support to work with all of
these features. Driver error recovery callbacks should be independent of
which feature the platform provides.
Add the generic PCI core error recovery files to the powerpc EEH
MAINTAINERS entry so the powerpc folks will be copied on changes to the
generic PCI error handling strategy.
Add Sam and Oliver as maintainers for this area.
Signed-off-by: Bjorn Helgaas <[email protected]>
diff --git a/MAINTAINERS b/MAINTAINERS
index 4ece30f15777..f23244003836 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11203,8 +11203,14 @@ F: tools/pci/
PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
M: Russell Currey <[email protected]>
+M: Sam Bobroff <[email protected]>
+M: Oliver O'Halloran <[email protected]>
L: [email protected]
S: Supported
+F: Documentation/PCI/pci-error-recovery.txt
+F: drivers/pci/pcie/aer.c
+F: drivers/pci/pcie/dpc.c
+F: drivers/pci/pcie/err.c
F: Documentation/powerpc/eeh-pci-error-recovery.txt
F: arch/powerpc/kernel/eeh*.c
F: arch/powerpc/platforms/*/eeh*.c
On Tue, 2018-09-18 at 16:58 -0500, Bjorn Helgaas wrote:
> On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > The original PCI error recovery functionality was for the powerpc-specific
> > IBM EEH feature. PCIe subsequently added some similar features, including
> > AER and DPC, that can be used on any architecture.
> >
> > We want the generic PCI core error handling support to work with all of
> > these features. Driver error recovery callbacks should be independent of
> > which feature the platform provides.
> >
> > Add the generic PCI core error recovery files to the powerpc EEH
> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > generic PCI error handling strategy.
> >
> > Signed-off-by: Bjorn Helgaas <[email protected]>
>
> I applied the following to for-linus for v4.19. Russell, if you want
> to be removed, let me know and I'll do that.
Oliver's email address for kernel stuff is [email protected], I think benh has been
CCing his IBM address. But other than that,
Acked-by: Russell Currey <[email protected]>
Thanks for this, Bjorn.
- Russell
>
> commit 3fed0e04026c
> Author: Bjorn Helgaas <[email protected]>
> Date: Wed Sep 12 11:55:26 2018 -0500
>
> MAINTAINERS: Update PPC contacts for PCI core error handling
>
> The original PCI error recovery functionality was for the powerpc-specific
> IBM EEH feature. PCIe subsequently added some similar features, including
> AER and DPC, that can be used on any architecture.
>
> We want the generic PCI core error handling support to work with all of
> these features. Driver error recovery callbacks should be independent of
> which feature the platform provides.
>
> Add the generic PCI core error recovery files to the powerpc EEH
> MAINTAINERS entry so the powerpc folks will be copied on changes to the
> generic PCI error handling strategy.
>
> Add Sam and Oliver as maintainers for this area.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4ece30f15777..f23244003836 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11203,8 +11203,14 @@ F: tools/pci/
>
> PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> M: Russell Currey <[email protected]>
> +M: Sam Bobroff <[email protected]>
> +M: Oliver O'Halloran <[email protected]>
> L: [email protected]
> S: Supported
> +F: Documentation/PCI/pci-error-recovery.txt
> +F: drivers/pci/pcie/aer.c
> +F: drivers/pci/pcie/dpc.c
> +F: drivers/pci/pcie/err.c
> F: Documentation/powerpc/eeh-pci-error-recovery.txt
> F: arch/powerpc/kernel/eeh*.c
> F: arch/powerpc/platforms/*/eeh*.c
On Wed, Sep 19, 2018 at 11:49:26AM +1000, Russell Currey wrote:
> On Tue, 2018-09-18 at 16:58 -0500, Bjorn Helgaas wrote:
> > On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <[email protected]>
> > >
> > > The original PCI error recovery functionality was for the powerpc-specific
> > > IBM EEH feature. PCIe subsequently added some similar features, including
> > > AER and DPC, that can be used on any architecture.
> > >
> > > We want the generic PCI core error handling support to work with all of
> > > these features. Driver error recovery callbacks should be independent of
> > > which feature the platform provides.
> > >
> > > Add the generic PCI core error recovery files to the powerpc EEH
> > > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > > generic PCI error handling strategy.
> > >
> > > Signed-off-by: Bjorn Helgaas <[email protected]>
> >
> > I applied the following to for-linus for v4.19. Russell, if you want
> > to be removed, let me know and I'll do that.
>
> Oliver's email address for kernel stuff is [email protected], I think benh has been
> CCing his IBM address. But other than that,
>
> Acked-by: Russell Currey <[email protected]>
I updated Oliver's email address and added your ack, thanks!
Bjorn Helgaas <[email protected]> writes:
> On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <[email protected]>
>>
>> The original PCI error recovery functionality was for the powerpc-specific
>> IBM EEH feature. PCIe subsequently added some similar features, including
>> AER and DPC, that can be used on any architecture.
>>
>> We want the generic PCI core error handling support to work with all of
>> these features. Driver error recovery callbacks should be independent of
>> which feature the platform provides.
>>
>> Add the generic PCI core error recovery files to the powerpc EEH
>> MAINTAINERS entry so the powerpc folks will be copied on changes to the
>> generic PCI error handling strategy.
>
> I really want to make sure the powerpc folks are plugged into any PCI core
> error handling discussions. Please let me know if there's a better way
> than this patch, or if there are other people who should be added.
Yeah this is a good option.
We powerpc folks also need to do a better job of keeping an eye on PCI
patches, I've asked more of us to subscribe to linux-pci.
cheers
On Tue, Sep 18, 2018 at 04:58:54PM -0500, Bjorn Helgaas wrote:
> On Wed, Sep 12, 2018 at 11:55:26AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <[email protected]>
> >
> > The original PCI error recovery functionality was for the powerpc-specific
> > IBM EEH feature. PCIe subsequently added some similar features, including
> > AER and DPC, that can be used on any architecture.
> >
> > We want the generic PCI core error handling support to work with all of
> > these features. Driver error recovery callbacks should be independent of
> > which feature the platform provides.
> >
> > Add the generic PCI core error recovery files to the powerpc EEH
> > MAINTAINERS entry so the powerpc folks will be copied on changes to the
> > generic PCI error handling strategy.
> >
> > Signed-off-by: Bjorn Helgaas <[email protected]>
>
> I applied the following to for-linus for v4.19. Russell, if you want
> to be removed, let me know and I'll do that.
Cheers!
Acked-by: Sam Bobroff <[email protected]>
> commit 3fed0e04026c
> Author: Bjorn Helgaas <[email protected]>
> Date: Wed Sep 12 11:55:26 2018 -0500
>
> MAINTAINERS: Update PPC contacts for PCI core error handling
>
> The original PCI error recovery functionality was for the powerpc-specific
> IBM EEH feature. PCIe subsequently added some similar features, including
> AER and DPC, that can be used on any architecture.
>
> We want the generic PCI core error handling support to work with all of
> these features. Driver error recovery callbacks should be independent of
> which feature the platform provides.
>
> Add the generic PCI core error recovery files to the powerpc EEH
> MAINTAINERS entry so the powerpc folks will be copied on changes to the
> generic PCI error handling strategy.
>
> Add Sam and Oliver as maintainers for this area.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4ece30f15777..f23244003836 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11203,8 +11203,14 @@ F: tools/pci/
>
> PCI ENHANCED ERROR HANDLING (EEH) FOR POWERPC
> M: Russell Currey <[email protected]>
> +M: Sam Bobroff <[email protected]>
> +M: Oliver O'Halloran <[email protected]>
> L: [email protected]
> S: Supported
> +F: Documentation/PCI/pci-error-recovery.txt
> +F: drivers/pci/pcie/aer.c
> +F: drivers/pci/pcie/dpc.c
> +F: drivers/pci/pcie/err.c
> F: Documentation/powerpc/eeh-pci-error-recovery.txt
> F: arch/powerpc/kernel/eeh*.c
> F: arch/powerpc/platforms/*/eeh*.c
>