2018-09-13 01:14:21

by Joshua Abraham

Subject: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

This patch removes duplicate macro useage in events_base.c.

It also fixes gcc warning:
variable ‘col’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Joshua Abraham <[email protected]>
---
drivers/xen/events/events_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 08e4af04d6f2..e6c1934734b7 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -138,7 +138,7 @@ static int set_evtchn_to_irq(unsigned evtchn, unsigned irq)
clear_evtchn_to_irq_row(row);
}

- evtchn_to_irq[EVTCHN_ROW(evtchn)][EVTCHN_COL(evtchn)] = irq;
+ evtchn_to_irq[row][col] = irq;
return 0;
}

--
2.17.1

2018-09-13 05:14:12

by Jürgen Groß

Subject: Re: [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

On 13/09/18 03:13, Josh Abraham wrote:
> This patch removes duplicate macro useage in events_base.c.
>
> It also fixes gcc warning:
> variable ‘col’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <[email protected]>

Reviewed-by: Juergen Gross <[email protected]>


Juergen

2018-09-13 23:01:56

by Boris Ostrovsky

Subject: Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

On 9/13/18 1:13 AM, Juergen Gross wrote:
> On 13/09/18 03:13, Josh Abraham wrote:
>> This patch removes duplicate macro useage in events_base.c.
>>
>> It also fixes gcc warning:
>> variable ‘col’ set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: Joshua Abraham <[email protected]>
> Reviewed-by: Juergen Gross <[email protected]>

Applied to for-linux-4.19b.

-boris