2018-09-13 07:59:33

by Christoph Manszewski

Subject: [PATCH 2/4] crypto: s5p-sss: Fix whitespace issues

Fix two whitespace issues that occurred at line breakup.

Signed-off-by: Christoph Manszewski <[email protected]>
---
drivers/crypto/s5p-sss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 0cf3f12d8f74..ce9bd13ea166 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -491,7 +491,7 @@ static void s5p_unset_indata(struct s5p_aes_dev *dev)
}

static int s5p_make_sg_cpy(struct s5p_aes_dev *dev, struct scatterlist *src,
- struct scatterlist **dst)
+ struct scatterlist **dst)
{
void *pages;
int len;
@@ -1890,7 +1890,7 @@ static int s5p_set_indata_start(struct s5p_aes_dev *dev,
}

static int s5p_set_outdata_start(struct s5p_aes_dev *dev,
- struct ablkcipher_request *req)
+ struct ablkcipher_request *req)
{
struct scatterlist *sg;
int err;
--
2.7.4

2018-09-17 13:07:49

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/4] crypto: s5p-sss: Fix whitespace issues

On Thu, 13 Sep 2018 at 09:59, Christoph Manszewski
<[email protected]> wrote:
>
> Fix two whitespace issues that occurred at line breakup.

The s5p_set_outdata_start() does not have issue - just new line is not
aligned. The other also is not a issue of whitespace (e.g. mixed
spaces and tabs) but alignment.
So how about:
"Fix misalignment of continued argument list."?

With commit and subject improvements:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

>
> Signed-off-by: Christoph Manszewski <[email protected]>
> ---
> drivers/crypto/s5p-sss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index 0cf3f12d8f74..ce9bd13ea166 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -491,7 +491,7 @@ static void s5p_unset_indata(struct s5p_aes_dev *dev)
> }
>
> static int s5p_make_sg_cpy(struct s5p_aes_dev *dev, struct scatterlist *src,
> - struct scatterlist **dst)
> + struct scatterlist **dst)
> {
> void *pages;
> int len;
> @@ -1890,7 +1890,7 @@ static int s5p_set_indata_start(struct s5p_aes_dev *dev,
> }
>
> static int s5p_set_outdata_start(struct s5p_aes_dev *dev,
> - struct ablkcipher_request *req)
> + struct ablkcipher_request *req)
> {
> struct scatterlist *sg;
> int err;
> --
> 2.7.4
>