2018-09-18 05:23:47

by Peter Hutterer

[permalink] [raw]

Subject: [PATCH] Input: uinput - allow for max == min during input_absinfo validation

---

These values are inclusive, so a range of 1 requires min == max.

Signed-off-by: Peter Hutterer <[email protected]>
---
drivers/input/misc/uinput.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index 96a887f33698..eb14ddf69346 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -410,7 +410,7 @@ static int uinput_validate_absinfo(struct input_dev *dev, unsigned int code,
min = abs->minimum;
max = abs->maximum;

- if ((min != 0 || max != 0) && max <= min) {
+ if ((min != 0 || max != 0) && max < min) {
printk(KERN_DEBUG
"%s: invalid abs[%02x] min:%d max:%d\n",
UINPUT_NAME, code, min, max);
--
2.17.1

2018-09-18 11:20:39

by Martin Kepplinger

[permalink] [raw]

Subject: Re: [PATCH] Input: uinput - allow for max == min during input_absinfo validation

---

On 9/18/18 7:22 AM, Peter Hutterer wrote:
> These values are inclusive, so a range of 1 requires min == max.
>
> Signed-off-by: Peter Hutterer <[email protected]>

true, nice catch.

Reviewed-by: Martin Kepplinger <[email protected]>

---

Attachments:

smime.p7s (3.53 kB)

2018-09-18 17:07:36

by Dmitry Torokhov

[permalink] [raw]

Subject: Re: [PATCH] Input: uinput - allow for max == min during input_absinfo validation

---

On Tue, Sep 18, 2018 at 01:13:47PM +0200, Martin Kepplinger wrote:
> On 9/18/18 7:22 AM, Peter Hutterer wrote:
> > These values are inclusive, so a range of 1 requires min == max.
> >
> > Signed-off-by: Peter Hutterer <[email protected]>
>
> true, nice catch.
>
> Reviewed-by: Martin Kepplinger <[email protected]>

Applied, thank you.

--
Dmitry