2018-09-22 14:44:20

by Chengguang Xu

Subject: [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits

Currently we show mount option "io_bits=%u" as "io_size=%uKB",
it will cause option parsing problem(unrecognized mount option)
in remount.

Signed-off-by: Chengguang Xu <[email protected]>
---
fs/f2fs/super.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 896b885f504e..8c96c4e9ee8d 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1336,7 +1336,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)
from_kgid_munged(&init_user_ns,
F2FS_OPTION(sbi).s_resgid));
if (F2FS_IO_SIZE_BITS(sbi))
- seq_printf(seq, ",io_size=%uKB", F2FS_IO_SIZE_KB(sbi));
+ seq_printf(seq, ",io_bits=%u",
+ F2FS_OPTION(sbi).write_io_size_bits);
#ifdef CONFIG_F2FS_FAULT_INJECTION
if (test_opt(sbi, FAULT_INJECTION)) {
seq_printf(seq, ",fault_injection=%u",
--
2.17.1

2018-09-25 07:43:14

by Chao Yu

Subject: Re: [f2fs-dev][PATCH] f2fs: fix remount problem of option io_bits

On 2018/9/22 22:43, Chengguang Xu wrote:
> Currently we show mount option "io_bits=%u" as "io_size=%uKB",
> it will cause option parsing problem(unrecognized mount option)
> in remount.
>
> Signed-off-by: Chengguang Xu <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,