2018-09-24 17:30:46

by Andreas Kemnade

Subject: [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

Pullup and down settings were missing, so add them to avoid
floating pins and make headset detection working.

Signed-off-by: Andreas Kemnade <[email protected]>
---
arch/arm/boot/dts/omap3-gta04.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 09e45e7ad4bc..6bcb459c1b20 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -657,6 +657,19 @@
status = "disabled";
};

+#define BIT(x) (1 << (x))
+&twl_gpio {
+ /* pullups: BIT(2) */
+ ti,pullups = <BIT(2)>;
+ /*
+ * pulldowns:
+ * BIT(0), BIT(1), BIT(6), BIT(7), BIT(8), BIT(13)
+ * BIT(15), BIT(16), BIT(17)
+ */
+ ti,pulldowns = <(BIT(0) | BIT(1) | BIT(6) | BIT(7) | BIT(8) |
+ BIT(13) | BIT(15) | BIT(16) | BIT(17))>;
+};
+
&twl_keypad {
status = "disabled";
};
--
2.11.0

2018-09-24 22:11:27

by Tony Lindgren

Subject: Re: [PATCH] ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

* Andreas Kemnade <[email protected]> [180924 10:34]:
> Pullup and down settings were missing, so add them to avoid
> floating pins and make headset detection working.

Applying into omap-for-v4.20/dt thanks.

Tony