LinuxLists.cc - [PATCH] staging: vc04_services: Update TODO re: arm64

2018-09-24 22:50:49

Subject: [PATCH] staging: vc04_services: Update TODO re: arm64

This patch removes the TODO item to remove manual cache flushing from b
ulk_receieve - this was done in 7e8dbea. Also remove the unnecessary
asm/cacheflush.h header.

Signed-off-by: Aymen Qader <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
2 files changed, 7 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index cefce72d814f..6c2b4ffe4996 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
hardware can do. If we exposed the native padding requirements
through the V4L2 "multiplanar" formats, the firmware would have one
less copy it needed to do.
-
-3) Port to ARM64
-
-The bulk_receive() does some manual cache flushing that are 32-bit ARM
-only, which we should convert to proper cross-platform APIs.
-
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 51e5b04ff0f5..6e5c1d4ee122 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/completion.h>
#include <linux/vmalloc.h>
-#include <asm/cacheflush.h>
#include <media/videobuf2-vmalloc.h>

#include "mmal-common.h"
--
2.17.1

2018-09-24 23:03:04

by Scott Branden

[permalink] [raw]

Subject: Re: [PATCH] staging: vc04_services: Update TODO re: arm64

Hi Aymen

On 18-09-24 03:48 PM, Aymen Qader wrote:
> This patch removes the TODO item to remove manual cache flushing from b
Remove the use of "This patch".
Please read
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
"Describe your changes in imperative mood"

Also, it looks like you broke "bulk_receive" across 2 lines.
Please correct and fix receive typo.
> ulk_receieve - this was done in 7e8dbea. Also remove the unnecessary
also read in the guidelines:
If you want to refer to a specific commit, don't just refer to the SHA-1
ID of the commit.
Please also include the oneline summary of the commit, to make it easier
for reviewers to know what it is about.
> asm/cacheflush.h header.
>
> Signed-off-by: Aymen Qader <[email protected]>
> ---
> drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
> index cefce72d814f..6c2b4ffe4996 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/TODO
> +++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
> @@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
> hardware can do. If we exposed the native padding requirements
> through the V4L2 "multiplanar" formats, the firmware would have one
> less copy it needed to do.
> -
> -3) Port to ARM64
> -
> -The bulk_receive() does some manual cache flushing that are 32-bit ARM
> -only, which we should convert to proper cross-platform APIs.
> -
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 51e5b04ff0f5..6e5c1d4ee122 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -21,7 +21,6 @@
> #include <linux/slab.h>
> #include <linux/completion.h>
> #include <linux/vmalloc.h>
> -#include <asm/cacheflush.h>
> #include <media/videobuf2-vmalloc.h>
>
> #include "mmal-common.h"

2018-09-24 23:36:25

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v2] staging: vc04_services: Update TODO re: arm64

Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:

(7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush
operations

Also remove the unnecessary asm/cacheflush.h header.

Signed-off-by: Aymen Qader <[email protected]>
---
v2: Make commit message clearer

drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
2 files changed, 7 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index cefce72d814f..6c2b4ffe4996 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
hardware can do. If we exposed the native padding requirements
through the V4L2 "multiplanar" formats, the firmware would have one
less copy it needed to do.
-
-3) Port to ARM64
-
-The bulk_receive() does some manual cache flushing that are 32-bit ARM
-only, which we should convert to proper cross-platform APIs.
-
diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 51e5b04ff0f5..6e5c1d4ee122 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/completion.h>
#include <linux/vmalloc.h>
-#include <asm/cacheflush.h>
#include <media/videobuf2-vmalloc.h>

#include "mmal-common.h"
--
2.17.1

2018-09-25 07:13:34

by Stefan Wahren

[permalink] [raw]

Subject: Re: [PATCH v2] staging: vc04_services: Update TODO re: arm64

Hi Aymen,

there are more than one TODO file in vc04_services (contains 3 drivers),
so here is my suggestion for the subject:

staging: bcm2835-camera: Update TODO

Am 25.09.2018 um 01:34 schrieb Aymen Qader:
> Remove the TODO item to remove manual cache flushing from bulk_receive.
> This was previously done in this commit:
>
> (7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush
> operations

please use this format, which should also make scripts/checkpatch.pl happy:

commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations ")

>
> Also remove the unnecessary asm/cacheflush.h header.

This doesn't match to the subject. Maybe a separate patch would be
better here.

Thanks
Stefan

>
> Signed-off-by: Aymen Qader <[email protected]>
> ---
> v2: Make commit message clearer
>
> drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
> 2 files changed, 7 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
> index cefce72d814f..6c2b4ffe4996 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/TODO
> +++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
> @@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
> hardware can do. If we exposed the native padding requirements
> through the V4L2 "multiplanar" formats, the firmware would have one
> less copy it needed to do.
> -
> -3) Port to ARM64
> -
> -The bulk_receive() does some manual cache flushing that are 32-bit ARM
> -only, which we should convert to proper cross-platform APIs.
> -
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> index 51e5b04ff0f5..6e5c1d4ee122 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
> @@ -21,7 +21,6 @@
> #include <linux/slab.h>
> #include <linux/completion.h>
> #include <linux/vmalloc.h>
> -#include <asm/cacheflush.h>
> #include <media/videobuf2-vmalloc.h>
>
> #include "mmal-common.h"

2018-09-25 08:34:43

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO

Update the bcm2835-camera driver to remove a TODO and an unused header
include. These were made unnecessary in

commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")

Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Remove unused header

--
v2: Make commit message clearer
v3: Separate patch into two, clean up commit messages

drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
2 files changed, 7 deletions(-)

--
2.17.1

2018-09-25 08:34:48

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 1/2] staging: bcm2835-camera: Update TODO

Remove the TODO item to remove manual cache flushing from bulk_receive.
This was previously done in this commit:

commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")

Signed-off-by: Aymen Qader <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/TODO b/drivers/staging/vc04_services/bcm2835-camera/TODO
index cefce72d814f..6c2b4ffe4996 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/TODO
+++ b/drivers/staging/vc04_services/bcm2835-camera/TODO
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the
hardware can do. If we exposed the native padding requirements
through the V4L2 "multiplanar" formats, the firmware would have one
less copy it needed to do.
-
-3) Port to ARM64
-
-The bulk_receive() does some manual cache flushing that are 32-bit ARM
-only, which we should convert to proper cross-platform APIs.
-
--
2.17.1

2018-09-25 08:34:55

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 2/2] staging: bcm2835-camera: Remove unused header

Remove the asm/cacheflush.h header include from mmal-vchiq.c. This
dependency was removed in:

commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
flush operations")

Signed-off-by: Aymen Qader <[email protected]>
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
index 51e5b04ff0f5..6e5c1d4ee122 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
@@ -21,7 +21,6 @@
#include <linux/slab.h>
#include <linux/completion.h>
#include <linux/vmalloc.h>
-#include <asm/cacheflush.h>
#include <media/videobuf2-vmalloc.h>

#include "mmal-common.h"
--
2.17.1

2018-09-25 08:35:01

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 2/2] staging: bcm2835-camera: Remove unused header

2018-09-25 08:35:37

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO

2018-09-25 08:35:57

by Aymen Qader

[permalink] [raw]

Subject: [PATCH v3 1/2] staging: bcm2835-camera: Update TODO

2018-09-25 20:42:32

by Stefan Wahren

[permalink] [raw]

Subject: Re: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO

> Aymen Qader <[email protected]> hat am 25. September 2018 um 10:33 geschrieben:
>
>
> Update the bcm2835-camera driver to remove a TODO and an unused header
> include. These were made unnecessary in
>
> commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
> flush operations")
>
> Aymen Qader (2):
> staging: bcm2835-camera: Update TODO
> staging: bcm2835-camera: Remove unused header

The whole series is

Acked-by: Stefan Wahren <[email protected]>

2018-09-26 00:33:27

by Scott Branden

[permalink] [raw]

Subject: Re: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO

Looks good now.

On 18-09-25 01:33 AM, Aymen Qader wrote:
> Update the bcm2835-camera driver to remove a TODO and an unused header
> include. These were made unnecessary in
>
> commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache
> flush operations")
>
> Aymen Qader (2):
> staging: bcm2835-camera: Update TODO
> staging: bcm2835-camera: Remove unused header
>
> --
> v2: Make commit message clearer
> v3: Separate patch into two, clean up commit messages
>
> drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------
> drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 -
> 2 files changed, 7 deletions(-)
>
Acked-by: Scott Branden <[email protected]>