2018-09-28 00:30:41

by r yang

Subject: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation

Document device tree bindings for ROHM BH1750 ambient light sensor driver.

Signed-off-by: ryang <[email protected]>
---
Changes in v4:
- Change example node-name to light-sensor

.../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt

diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
new file mode 100644
index 000000000000..1e7685797d7a
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
@@ -0,0 +1,18 @@
+ROHM BH1750 - ALS, Ambient light sensor
+
+Required properties:
+
+- compatible: Must be one of:
+ "rohm,bh1710"
+ "rohm,bh1715"
+ "rohm,bh1721"
+ "rohm,bh1750"
+ "rohm,bh1751"
+- reg: the I2C address of the sensor
+
+Example:
+
+light-sensor@23 {
+ compatible = "rohm,bh1750";
+ reg = <0x23>;
+};
--
2.17.1

2018-09-28 00:30:44

by r yang

Subject: [PATCH v4 2/2] iio: light: bh1750: Add device tree support

Add device tree support for ROHM BH1750 series ambient light sensors.

Signed-off-by: ryang <[email protected]>
---
drivers/iio/light/bh1750.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
index c3a481452b67..28347df78cff 100644
--- a/drivers/iio/light/bh1750.c
+++ b/drivers/iio/light/bh1750.c
@@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
};
MODULE_DEVICE_TABLE(i2c, bh1750_id);

+static const struct of_device_id bh1750_of_match[] = {
+ { .compatible = "rohm,bh1710", },
+ { .compatible = "rohm,bh1715", },
+ { .compatible = "rohm,bh1721", },
+ { .compatible = "rohm,bh1750", },
+ { .compatible = "rohm,bh1751", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, bh1750_of_match);
+
static struct i2c_driver bh1750_driver = {
.driver = {
.name = "bh1750",
+ .of_match_table = bh1750_of_match,
.pm = &bh1750_pm_ops,
},
.probe = bh1750_probe,
--
2.17.1

2018-09-29 11:52:59

by Jonathan Cameron

Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: bh1750: Add device tree binding documentation

On Thu, 27 Sep 2018 20:29:57 -0400
ryang <[email protected]> wrote:

> Document device tree bindings for ROHM BH1750 ambient light sensor driver.
>
> Signed-off-by: ryang <[email protected]>
As I'd already applied v3 (prematurely :() I fixed that up directly.

Thanks,

Jonathan

> ---
> Changes in v4:
> - Change example node-name to light-sensor
>
> .../devicetree/bindings/iio/light/bh1750.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/bh1750.txt b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> new file mode 100644
> index 000000000000..1e7685797d7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/bh1750.txt
> @@ -0,0 +1,18 @@
> +ROHM BH1750 - ALS, Ambient light sensor
> +
> +Required properties:
> +
> +- compatible: Must be one of:
> + "rohm,bh1710"
> + "rohm,bh1715"
> + "rohm,bh1721"
> + "rohm,bh1750"
> + "rohm,bh1751"
> +- reg: the I2C address of the sensor
> +
> +Example:
> +
> +light-sensor@23 {
> + compatible = "rohm,bh1750";
> + reg = <0x23>;
> +};