2018-09-29 19:11:42

by Andrey Abramov

Subject: [PATCH] Staging: media: replaced deprecated probe method

drivers/staging/media/bcm2048/radio-bcm2048.c replaced i2c_driver::probe with i2c_driver::probe_new, because documentation says that i2c_driver::probe "soon to be deprecated"

Signed-off-by: Andrey Abramov <[email protected]>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index a90b2eb112f9..756f7f08c713 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2574,8 +2574,7 @@ static const struct video_device bcm2048_viddev_template = {
/*
* I2C driver interface
*/
-static int bcm2048_i2c_driver_probe(struct i2c_client *client,
- const struct i2c_device_id *id)
+static int bcm2048_i2c_driver_probe_new(struct i2c_client *client)
{
struct bcm2048_device *bdev;
int err;
@@ -2679,7 +2678,7 @@ static struct i2c_driver bcm2048_i2c_driver = {
.driver = {
.name = BCM2048_DRIVER_NAME,
},
- .probe = bcm2048_i2c_driver_probe,
+ .probe_new = bcm2048_i2c_driver_probe_new,
.remove = bcm2048_i2c_driver_remove,
.id_table = bcm2048_id,
};
--
2.19.0

2018-10-01 06:48:55

by Dan Carpenter

Subject: Re: [PATCH] Staging: media: replaced deprecated probe method

On Sat, Sep 29, 2018 at 09:51:50PM +0300, Andrey Abramov wrote:
> drivers/staging/media/bcm2048/radio-bcm2048.c replaced i2c_driver::probe with i2c_driver::probe_new, because documentation says that i2c_driver::probe "soon to be deprecated"
>

This needs to be line wrapped at 72 characters.

> Signed-off-by: Andrey Abramov <[email protected]>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index a90b2eb112f9..756f7f08c713 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2574,8 +2574,7 @@ static const struct video_device bcm2048_viddev_template = {
> /*
> * I2C driver interface
> */
> -static int bcm2048_i2c_driver_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int bcm2048_i2c_driver_probe_new(struct i2c_client *client)

Don't rename the function. Just remove the unused parameter.

regards,
dan carpenter