2018-10-01 09:56:41

by Niklas Cassel

Subject: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
hidden kconfig, so it is not selectable in menuconfig.

Remove the help text so that it is more clear that this is intentionally
a hidden kconfig.

Signed-off-by: Niklas Cassel <[email protected]>
---
drivers/soc/qcom/Kconfig | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 684cb51694d1..fcbf8a2e4080 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
tristate
depends on ARCH_QCOM || COMPILE_TEST
depends on NET
- help
- Helper library for handling QMI encoded messages. QMI encoded
- messages are used in communication between the majority of QRTR
- clients and this helpers provide the common functionality needed for
- doing this from a kernel driver.

config QCOM_RMTFS_MEM
tristate "Qualcomm Remote Filesystem memory driver"
--
2.17.1

2018-10-01 12:11:00

by Alex Elder

Subject: Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

On 10/01/2018 04:55 AM, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <[email protected]>

Looks good to me. If someone needs it, they know what it's for.

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/soc/qcom/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 684cb51694d1..fcbf8a2e4080 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
> tristate
> depends on ARCH_QCOM || COMPILE_TEST
> depends on NET
> - help
> - Helper library for handling QMI encoded messages. QMI encoded
> - messages are used in communication between the majority of QRTR
> - clients and this helpers provide the common functionality needed for
> - doing this from a kernel driver.
>
> config QCOM_RMTFS_MEM
> tristate "Qualcomm Remote Filesystem memory driver"
>

2018-10-02 03:57:53

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

On Mon 01 Oct 02:55 PDT 2018, Niklas Cassel wrote:

> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/soc/qcom/Kconfig | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 684cb51694d1..fcbf8a2e4080 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -75,11 +75,6 @@ config QCOM_QMI_HELPERS
> tristate
> depends on ARCH_QCOM || COMPILE_TEST
> depends on NET
> - help
> - Helper library for handling QMI encoded messages. QMI encoded
> - messages are used in communication between the majority of QRTR
> - clients and this helpers provide the common functionality needed for
> - doing this from a kernel driver.
>
> config QCOM_RMTFS_MEM
> tristate "Qualcomm Remote Filesystem memory driver"
> --
> 2.17.1
>

2018-11-14 18:07:10

by Andy Gross

Subject: Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

On Mon, Oct 01, 2018 at 11:55:54AM +0200, Niklas Cassel wrote:
> The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a
> hidden kconfig, so it is not selectable in menuconfig.
>
> Remove the help text so that it is more clear that this is intentionally
> a hidden kconfig.
>
> Signed-off-by: Niklas Cassel <[email protected]>
> ---

Added to queue. Thanks.

Andy