From: Bartosz Golaszewski <[email protected]>
The following warning is produced when building nvmem core if
CONFIG_OF is disabled:
drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
^~~~~~~~~~~~~~~~~~~~~~~~
This is caused by the fact that the only caller of this routine is
under an ifdef depending on this option. Fix it by adding a relevant
ifdef to the function in question as well.
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/nvmem/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index cc815bb2eebd..65f61cd0a687 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -492,6 +492,7 @@ static int nvmem_add_cells_from_table(struct nvmem_device *nvmem)
return rval;
}
+#if IS_ENABLED(CONFIG_OF)
static struct nvmem_cell *
nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
{
@@ -507,6 +508,7 @@ nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
return cell;
}
+#endif
static struct nvmem_cell *
nvmem_find_cell_by_name(struct nvmem_device *nvmem, const char *cell_id)
--
2.19.0
On 02/10/18 12:02, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> This is caused by the fact that the only caller of this routine is
> under an ifdef depending on this option. Fix it by adding a relevant
> ifdef to the function in question as well.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/nvmem/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index cc815bb2eebd..65f61cd0a687 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -492,6 +492,7 @@ static int nvmem_add_cells_from_table(struct nvmem_device *nvmem)
> return rval;
> }
>
> +#if IS_ENABLED(CONFIG_OF)
You should probably attribute the function with "__maybe_unused"
Instead of adding this condition.
--srini
> static struct nvmem_cell *
> nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> {
> @@ -507,6 +508,7 @@ nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
>
> return cell;
> }
> +#endif
>
> static struct nvmem_cell *
> nvmem_find_cell_by_name(struct nvmem_device *nvmem, const char *cell_id)
>
wt., 2 paź 2018 o 13:49 Srinivas Kandagatla
<[email protected]> napisał(a):
>
>
>
> On 02/10/18 12:02, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <[email protected]>
> >
> > The following warning is produced when building nvmem core if
> > CONFIG_OF is disabled:
> >
> > drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> > nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > This is caused by the fact that the only caller of this routine is
> > under an ifdef depending on this option. Fix it by adding a relevant
> > ifdef to the function in question as well.
> >
> > Signed-off-by: Bartosz Golaszewski <[email protected]>
> > ---
> > drivers/nvmem/core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index cc815bb2eebd..65f61cd0a687 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -492,6 +492,7 @@ static int nvmem_add_cells_from_table(struct nvmem_device *nvmem)
> > return rval;
> > }
> >
> > +#if IS_ENABLED(CONFIG_OF)
>
> You should probably attribute the function with "__maybe_unused"
> Instead of adding this condition.
>
Sounds better indeed. I'll resend tomorrow to avoid spamming.
Bart
> --srini
>
>
> > static struct nvmem_cell *
> > nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> > {
> > @@ -507,6 +508,7 @@ nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> >
> > return cell;
> > }
> > +#endif
> >
> > static struct nvmem_cell *
> > nvmem_find_cell_by_name(struct nvmem_device *nvmem, const char *cell_id)
> >
On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The following warning is produced when building nvmem core if
> CONFIG_OF is disabled:
>
> drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> This is caused by the fact that the only caller of this routine is
> under an ifdef depending on this option. Fix it by adding a relevant
> ifdef to the function in question as well.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
No "reported-by:" lines on this and the other patch?
Not nice :(
śr., 3 paź 2018 o 00:26 Greg KH <[email protected]> napisał(a):
>
> On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <[email protected]>
> >
> > The following warning is produced when building nvmem core if
> > CONFIG_OF is disabled:
> >
> > drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> > nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > This is caused by the fact that the only caller of this routine is
> > under an ifdef depending on this option. Fix it by adding a relevant
> > ifdef to the function in question as well.
> >
> > Signed-off-by: Bartosz Golaszewski <[email protected]>
>
> No "reported-by:" lines on this and the other patch?
>
> Not nice :(
Sorry, I normally remeber about it. Anyway Arnd sent a better
alternative for this one.
Bart