2018-10-13 01:33:40

by Masanari Iida

[permalink] [raw]
Subject: [PATCH] docs: Fix typos in histogram.rst

This patch fixes some spelling typos.

Signed-off-by: Masanari Iida <[email protected]>
---
Documentation/trace/histogram.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
index 5ac724baea7d..7dda76503127 100644
--- a/Documentation/trace/histogram.rst
+++ b/Documentation/trace/histogram.rst
@@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
# echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
# echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger

-In the first line above, the event's timetamp is saved into the
+In the first line above, the event's timestamp is saved into the
variable ts0. In the next line, ts0 is subtracted from the second
event's timestamp to produce the latency, which is then assigned into
yet another variable, 'wakeup_lat'. The hist trigger below in turn
@@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
/sys/kernel/debug/tracing/synthetic_events

At this point, there isn't yet an actual 'wakeup_latency' event
-instantiated in the event subsytem - for this to happen, a 'hist
+instantiated in the event subsystem - for this to happen, a 'hist
trigger action' needs to be instantiated and bound to actual fields
and variables defined on other events (see Section 2.2.3 below on
how that is done using hist trigger 'onmatch' action). Once that is
@@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
A hist trigger 'action' is a function that's executed whenever a
histogram entry is added or updated.

-The default 'action' if no special function is explicity specified is
+The default 'action' if no special function is explicitly specified is
as it always has been, to simply update the set of values associated
with an entry. Some applications, however, may want to perform
additional actions at that point, such as generate another event, or
--
2.19.1.328.g5a0cc8aca797



2018-10-13 01:35:56

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] docs: Fix typos in histogram.rst

On 10/12/18 6:30 PM, Masanari Iida wrote:
> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> Documentation/trace/histogram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Randy Dunlap <[email protected]>

thanks.
--
~Randy

2018-10-13 02:05:58

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] docs: Fix typos in histogram.rst

On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <[email protected]> wrote:

> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> Documentation/trace/histogram.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/trace/histogram.rst b/Documentation/trace/histogram.rst
> index 5ac724baea7d..7dda76503127 100644
> --- a/Documentation/trace/histogram.rst
> +++ b/Documentation/trace/histogram.rst
> @@ -1765,7 +1765,7 @@ For example, here's how a latency can be calculated::
> # echo 'hist:keys=pid,prio:ts0=common_timestamp ...' >> event1/trigger
> # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp-$ts0 ...' >> event2/trigger
>
> -In the first line above, the event's timetamp is saved into the
> +In the first line above, the event's timestamp is saved into the
> variable ts0. In the next line, ts0 is subtracted from the second
> event's timestamp to produce the latency, which is then assigned into
> yet another variable, 'wakeup_lat'. The hist trigger below in turn
> @@ -1811,7 +1811,7 @@ the command that defined it with a '!'::
> /sys/kernel/debug/tracing/synthetic_events
>
> At this point, there isn't yet an actual 'wakeup_latency' event
> -instantiated in the event subsytem - for this to happen, a 'hist
> +instantiated in the event subsystem - for this to happen, a 'hist

The first two appear to show that Tom has a faulty 's' key ;-)

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve



> trigger action' needs to be instantiated and bound to actual fields
> and variables defined on other events (see Section 2.2.3 below on
> how that is done using hist trigger 'onmatch' action). Once that is
> @@ -1837,7 +1837,7 @@ output can be displayed by reading the event's 'hist' file.
> A hist trigger 'action' is a function that's executed whenever a
> histogram entry is added or updated.
>
> -The default 'action' if no special function is explicity specified is
> +The default 'action' if no special function is explicitly specified is
> as it always has been, to simply update the set of values associated
> with an entry. Some applications, however, may want to perform
> additional actions at that point, such as generate another event, or


2018-10-18 18:58:02

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] docs: Fix typos in histogram.rst

On Sat, 13 Oct 2018 10:30:57 +0900
Masanari Iida <[email protected]> wrote:

> This patch fixes some spelling typos.
>
> Signed-off-by: Masanari Iida <[email protected]>

Applied, thanks.

jon