2018-10-16 04:36:06

by Masahiro Yamada

Subject: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>

The reason of including <linux/bitops.h> here is just for BIT() and
GENMASK macros.

Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
macros from <linux/bitops.h> to a new <linux/bits.h> file"),
<linux/bits.h> is enough for such compile-time macros.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/mtd/nand/raw/denali.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
index 57a5498..25c0060 100644
--- a/drivers/mtd/nand/raw/denali.h
+++ b/drivers/mtd/nand/raw/denali.h
@@ -7,7 +7,7 @@
#ifndef __DENALI_H__
#define __DENALI_H__

-#include <linux/bitops.h>
+#include <linux/bits.h>
#include <linux/completion.h>
#include <linux/mtd/rawnand.h>
#include <linux/spinlock_types.h>
--
2.7.4

2018-10-16 12:01:50

by Boris Brezillon

Subject: Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>

On Tue, 16 Oct 2018 13:33:21 +0900
Masahiro Yamada <[email protected]> wrote:

> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Boris Brezillon <[email protected]>

> ---
>
> drivers/mtd/nand/raw/denali.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/denali.h b/drivers/mtd/nand/raw/denali.h
> index 57a5498..25c0060 100644
> --- a/drivers/mtd/nand/raw/denali.h
> +++ b/drivers/mtd/nand/raw/denali.h
> @@ -7,7 +7,7 @@
> #ifndef __DENALI_H__
> #define __DENALI_H__
>
> -#include <linux/bitops.h>
> +#include <linux/bits.h>
> #include <linux/completion.h>
> #include <linux/mtd/rawnand.h>
> #include <linux/spinlock_types.h>

2018-11-11 20:54:46

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: denali: include <linux/bits.h> instead of <linux/bitops.h>

Hi Masahiro,

Masahiro Yamada <[email protected]> wrote on Tue, 16 Oct
2018 13:33:21 +0900:

> The reason of including <linux/bitops.h> here is just for BIT() and
> GENMASK macros.
>
> Since commit 8bd9cb51daac8 ("locking/atomics, asm-generic: Move some
> macros from <linux/bitops.h> to a new <linux/bits.h> file"),
> <linux/bits.h> is enough for such compile-time macros.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Applied to nand/next.

Thanks,
Miquèl