2018-10-16 16:03:27

by Marcelo Schmitt

Subject: [PATCH] Staging iio/adc: fixes parenthesis alignment

Fixes close parenthesis alignment to match open parenthesis at
iio/drivers/staging/iio/adc/ad7606.c line 379.

Signed-of-by: Marcelo Schmitt <[email protected]>
---
drivers/staging/iio/adc/ad7606.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/adc/ad7606.c b/drivers/staging/iio/adc/ad7606.c
index 0b728b6ea135..230faae38c12 100644
--- a/drivers/staging/iio/adc/ad7606.c
+++ b/drivers/staging/iio/adc/ad7606.c
@@ -376,7 +376,7 @@ static int ad7606_request_gpios(struct ad7606_state *st)
return 0;

st->gpio_os = devm_gpiod_get_array_optional(dev, "oversampling-ratio",
- GPIOD_OUT_LOW);
+ GPIOD_OUT_LOW);
return PTR_ERR_OR_ZERO(st->gpio_os);
}

--
2.17.1

2018-10-17 15:45:29

by Shreeya Patel

Subject: Re: [PATCH] Staging iio/adc: fixes parenthesis alignment

On Tue, 2018-10-16 at 13:01 -0300, Marcelo Schmitt wrote:
> Fixes close parenthesis alignment to match open parenthesis at
> iio/drivers/staging/iio/adc/ad7606.c line 379.
>
> Signed-of-by: Marcelo Schmitt <[email protected]>

Hi Marcelo,

Some suggestions from my side....

1) Your subject line should look like "Staging: iio: adc:" instead of
"Staging iio/adc:"
This is the pattern that everyone in the Linux Kernel community has to
follow for having consistency around.

2) Your subject line and commit message should be in the imperative
form.

For example :-
Staging: iio: adc: Match alignment with open parenthesis

Similar should be the case for commit message.

3) Try to avoid the word 'fix' as it becomes an easy way for
people to avoid explanation for the patch.
Try giving more information about what you are doing and why are you
doing that.

You can have a look here
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/comm
it/?id=efd44cf468fe7e7ff9150dc52879426e0d0801eb

Bdw, good try if it's your first patch :)

Thanks

> ---
> drivers/staging/iio/adc/ad7606.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7606.c
> b/drivers/staging/iio/adc/ad7606.c
> index 0b728b6ea135..230faae38c12 100644
> --- a/drivers/staging/iio/adc/ad7606.c
> +++ b/drivers/staging/iio/adc/ad7606.c
> @@ -376,7 +376,7 @@ static int ad7606_request_gpios(struct
> ad7606_state *st)
> return 0;
>
> st->gpio_os = devm_gpiod_get_array_optional(dev,
> "oversampling-ratio",
> - GPIOD_OUT_LOW);
> + GPIOD_OUT_LOW);
> return PTR_ERR_OR_ZERO(st->gpio_os);
> }
>

2018-10-18 06:08:58

by Dan Carpenter

Subject: Re: [PATCH] Staging iio/adc: fixes parenthesis alignment

I feel like these are overly nit-picky...

I understand that everyone is picky about different things. For
example, I have a prefered style for error handling. So two days ago
there was a new staging driver and it used label name like
"goto kmalloc_failed;" and I looked until I found an error handling bug
and then I said, "Here is a bug, plus your label names are bad." When
people have bad style but it doesn't lead to bugs then I let them get
away with it.

regards,
dan carpenter