2018-10-04 13:57:39

by Gustavo A. R. Silva

[permalink] [raw]

Subject: [PATCH] power: max8925: mark expected switch fall-through

---

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 201510 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/power/supply/max8925_power.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c
index 3b94620..39b4d5b 100644
--- a/drivers/power/supply/max8925_power.c
+++ b/drivers/power/supply/max8925_power.c
@@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data)
case MAX8925_IRQ_VCHG_THM_OK_F:
/* Battery is not ready yet */
dev_dbg(chip->dev, "Battery temperature is out of range\n");
+ /* Fall through */
case MAX8925_IRQ_VCHG_DC_OVP:
dev_dbg(chip->dev, "Error detection\n");
__set_charger(info, 0);
--
2.7.4

2018-10-21 19:35:41

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: max8925: mark expected switch fall-through

---

Hi,

On Thu, Oct 04, 2018 at 03:56:36PM +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 201510 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/max8925_power.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c
> index 3b94620..39b4d5b 100644
> --- a/drivers/power/supply/max8925_power.c
> +++ b/drivers/power/supply/max8925_power.c
> @@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data)
> case MAX8925_IRQ_VCHG_THM_OK_F:
> /* Battery is not ready yet */
> dev_dbg(chip->dev, "Battery temperature is out of range\n");
> + /* Fall through */
> case MAX8925_IRQ_VCHG_DC_OVP:
> dev_dbg(chip->dev, "Error detection\n");
> __set_charger(info, 0);
> --
> 2.7.4
>

---

Attachments:

(No filename) (1.03 kB)
signature.asc (849.00 B)
Download all attachments