2018-10-25 07:55:03

by Jürgen Groß

Subject: [PATCH] xen/pvh: don't try to unplug emulated devices

A Xen PVH guest has no associated qemu device model, so trying to
unplug any emulated devices is making no sense at all.

Bail out early from xen_unplug_emulated_devices() when running as PVH
guest. This will avoid issuing the boot message:

[ 0.000000] Xen Platform PCI: unrecognised magic value

Cc: <[email protected]> # 4.11
Signed-off-by: Juergen Gross <[email protected]>
---
arch/x86/xen/platform-pci-unplug.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
index 66ab96a4e2b3..96d7f7d39cb9 100644
--- a/arch/x86/xen/platform-pci-unplug.c
+++ b/arch/x86/xen/platform-pci-unplug.c
@@ -134,6 +134,10 @@ void xen_unplug_emulated_devices(void)
{
int r;

+ /* PVH guests don't have emulated devices. */
+ if (xen_pvh_domain())
+ return;
+
/* user explicitly requested no unplug */
if (xen_emul_unplug & XEN_UNPLUG_NEVER)
return;
--
2.16.4

2018-10-25 12:17:50

by Boris Ostrovsky

Subject: Re: [PATCH] xen/pvh: don't try to unplug emulated devices

On 10/25/18 3:54 AM, Juergen Gross wrote:
> A Xen PVH guest has no associated qemu device model, so trying to
> unplug any emulated devices is making no sense at all.
>
> Bail out early from xen_unplug_emulated_devices() when running as PVH
> guest. This will avoid issuing the boot message:
>
> [ 0.000000] Xen Platform PCI: unrecognised magic value
>
> Cc: <[email protected]> # 4.11
> Signed-off-by: Juergen Gross <[email protected]>

Reviewed-by: Boris Ostrovsky <[email protected]>