Remove unneeded parentheses around the arguments of ||. This reduces
clutter and code behave in the same way.
Change suggested by checkpatch.pl.
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
crtc->x'
Signed-off-by: Shayenne da Luz Moura <[email protected]>
---
Changes in v2:
- Make the commit message more clearer.
drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
index 429f6a453619..10a862674789 100644
--- a/drivers/staging/vboxvideo/vbox_main.c
+++ b/drivers/staging/vboxvideo/vbox_main.c
@@ -116,10 +116,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
struct vbva_cmd_hdr cmd_hdr;
unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;
- if ((rects[i].x1 > crtc->x + crtc->hwmode.hdisplay) ||
- (rects[i].y1 > crtc->y + crtc->hwmode.vdisplay) ||
- (rects[i].x2 < crtc->x) ||
- (rects[i].y2 < crtc->y))
+ if (rects[i].x1 > crtc->x + crtc->hwmode.hdisplay ||
+ rects[i].y1 > crtc->y + crtc->hwmode.vdisplay ||
+ rects[i].x2 < crtc->x ||
+ rects[i].y2 < crtc->y)
continue;
cmd_hdr.x = (s16)rects[i].x1;
--
2.19.1
Hi,
On 23-10-18 19:43, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
>
> Signed-off-by: Shayenne da Luz Moura <[email protected]>
Patch looks good to me:
Reviewed-by: Hans de Goede <[email protected]>
Regards,
Hans
> ---
> Changes in v2:
> - Make the commit message more clearer.
>
> drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index 429f6a453619..10a862674789 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -116,10 +116,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
> struct vbva_cmd_hdr cmd_hdr;
> unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;
>
> - if ((rects[i].x1 > crtc->x + crtc->hwmode.hdisplay) ||
> - (rects[i].y1 > crtc->y + crtc->hwmode.vdisplay) ||
> - (rects[i].x2 < crtc->x) ||
> - (rects[i].y2 < crtc->y))
> + if (rects[i].x1 > crtc->x + crtc->hwmode.hdisplay ||
> + rects[i].y1 > crtc->y + crtc->hwmode.vdisplay ||
> + rects[i].x2 < crtc->x ||
> + rects[i].y2 < crtc->y)
> continue;
>
> cmd_hdr.x = (s16)rects[i].x1;
>
On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
>
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
>
> Signed-off-by: Shayenne da Luz Moura <[email protected]>
> Reviewed-by: Hans de Goede <[email protected]>
> ---
> Changes in v2:
> - Make the commit message more clearer.
This patch does not apply to the latest kernel tree at all :(
Please fix up and resend.
thanks,
greg k-h
On 10/30, Greg Kroah-Hartman wrote:
> On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> > Remove unneeded parentheses around the arguments of ||. This reduces
> > clutter and code behave in the same way.
> > Change suggested by checkpatch.pl.
> >
> > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> > crtc->x'
> >
> > Signed-off-by: Shayenne da Luz Moura <[email protected]>
> > Reviewed-by: Hans de Goede <[email protected]>
> > ---
> > Changes in v2:
> > - Make the commit message more clearer.
>
> This patch does not apply to the latest kernel tree at all :(
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
Hi Greg!
Sorry, I do not know what branch are expected to be used.
I used the drm-misc-next to create this patch and I could not
find any merge problem.
Could you please tell me the details?
Thanks,
Shayenne
On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote:
>On 10/30, Greg Kroah-Hartman wrote:
>> On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
>> > Remove unneeded parentheses around the arguments of ||. This reduces
>> > clutter and code behave in the same way.
>> > Change suggested by checkpatch.pl.
>> >
>> > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
>> > crtc->x'
>> >
>> > Signed-off-by: Shayenne da Luz Moura <[email protected]>
>> > Reviewed-by: Hans de Goede <[email protected]>
>> > ---
>> > Changes in v2:
>> > - Make the commit message more clearer.
>>
>> This patch does not apply to the latest kernel tree at all :(
>>
>> Please fix up and resend.
>>
>> thanks,
>>
>> greg k-h
>
>Hi Greg!
>
>Sorry, I do not know what branch are expected to be used.
>I used the drm-misc-next to create this patch and I could not
>find any merge problem.
>
>Could you please tell me the details?
Hi Shayenne,
There's an easy trick for this: the kernel tree has a script that can
help you find both the relevant maintainers, and their development tree
for each file in the kernel.
Simply run:
./scripts/get_maintainer.pl --scm -f [filename]
For example, in this case, you'd run:
$ ./scripts/get_maintainer.pl --scm -f drivers/staging/vboxvideo/vbox_main.c
Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM,commit_signer:10/10=100%)
Hans de Goede <[email protected]> (commit_signer:7/10=70%,authored:6/10=60%,added_lines:31/37=84%,removed_lines:153/159=96%)
Fabio Rafael da Rosa <[email protected]> (commit_signer:1/10=10%,authored:1/10=10%)
Alexander Kapshuk <[email protected]> (commit_signer:1/10=10%,authored:1/10=10%)
Nicholas Mc Guire <[email protected]> (commit_signer:1/10=10%)
Thomas Zimmermann <[email protected]> (authored:1/10=10%,added_lines:2/37=5%)
Daniel Junho <[email protected]> (authored:1/10=10%,added_lines:2/37=5%)
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
The list of people and mailing lists are the ones that should be the
recipients of your patch, and the last line is the git tree on which the
patch should be based on.
--
Thanks,
Sasha
On Tue, 30 Oct 2018, Shayenne Moura wrote:
> On 10/30, Greg Kroah-Hartman wrote:
> > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> > > Remove unneeded parentheses around the arguments of ||. This reduces
> > > clutter and code behave in the same way.
> > > Change suggested by checkpatch.pl.
> > >
> > > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> > > crtc->x'
> > >
> > > Signed-off-by: Shayenne da Luz Moura <[email protected]>
> > > Reviewed-by: Hans de Goede <[email protected]>
> > > ---
> > > Changes in v2:
> > > - Make the commit message more clearer.
> >
> > This patch does not apply to the latest kernel tree at all :(
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg!
>
> Sorry, I do not know what branch are expected to be used.
> I used the drm-misc-next to create this patch and I could not
> find any merge problem.
>
> Could you please tell me the details?
For staging drivers you should use the staging tree as indicated in the
outreachy tutorial.
julia
>
> Thanks,
>
> Shayenne
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181030231757.24ooubt25oykmgkt%40smtp.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
On 10/30, Sasha Levin wrote:
> On Tue, Oct 30, 2018 at 08:17:57PM -0300, Shayenne Moura wrote:
> > On 10/30, Greg Kroah-Hartman wrote:
> > > On Tue, Oct 23, 2018 at 02:43:04PM -0300, Shayenne da Luz Moura wrote:
> > > > Remove unneeded parentheses around the arguments of ||. This reduces
> > > > clutter and code behave in the same way.
> > > > Change suggested by checkpatch.pl.
> > > >
> > > > vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> > > > crtc->x'
> > > >
> > > > Signed-off-by: Shayenne da Luz Moura <[email protected]>
> > > > Reviewed-by: Hans de Goede <[email protected]>
> > > > ---
> > > > Changes in v2:
> > > > - Make the commit message more clearer.
> > >
> > > This patch does not apply to the latest kernel tree at all :(
> > >
> > > Please fix up and resend.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi Greg!
> >
> > Sorry, I do not know what branch are expected to be used.
> > I used the drm-misc-next to create this patch and I could not
> > find any merge problem.
> >
> > Could you please tell me the details?
>
> Hi Shayenne,
>
> There's an easy trick for this: the kernel tree has a script that can
> help you find both the relevant maintainers, and their development tree
> for each file in the kernel.
>
> Simply run:
>
> ./scripts/get_maintainer.pl --scm -f [filename]
>
> For example, in this case, you'd run:
>
> $ ./scripts/get_maintainer.pl --scm -f drivers/staging/vboxvideo/vbox_main.c
> Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM,commit_signer:10/10=100%)
> Hans de Goede <[email protected]> (commit_signer:7/10=70%,authored:6/10=60%,added_lines:31/37=84%,removed_lines:153/159=96%)
> Fabio Rafael da Rosa <[email protected]> (commit_signer:1/10=10%,authored:1/10=10%)
> Alexander Kapshuk <[email protected]> (commit_signer:1/10=10%,authored:1/10=10%)
> Nicholas Mc Guire <[email protected]> (commit_signer:1/10=10%)
> Thomas Zimmermann <[email protected]> (authored:1/10=10%,added_lines:2/37=5%)
> Daniel Junho <[email protected]> (authored:1/10=10%,added_lines:2/37=5%)
> [email protected] (open list:STAGING SUBSYSTEM)
> [email protected] (open list)
> git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> The list of people and mailing lists are the ones that should be the
> recipients of your patch, and the last line is the git tree on which the
> patch should be based on.
>
> --
> Thanks,
> Sasha
Thanks Sasha!
It is a very nice tip!
Best regards,
Shayenne