2018-11-02 19:11:53

by Aaro Koskinen

Subject: [PATCH v3] arm64: dts: stratix10: fix multicast filtering

From: Aaro Koskinen <[email protected]>

On Stratix 10, the EMAC has 256 hash buckets for multicast filtering. This
needs to be specified in DTS, otherwise the stmmac driver defaults to 64
buckets and initializes the filter incorrectly. As a result, e.g. valid
IPv6 multicast traffic ends up being dropped.

Fixes: 78cd6a9d8e15 ("arm64: dts: Add base stratix 10 dtsi")
Signed-off-by: Aaro Koskinen <[email protected]>
---
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
1 file changed, 3 insertions(+)

v3: Send the patch using sane SMTP server to preserve the correct
formatting.

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 8253a1a9e985..fef7351e9f67 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -139,6 +139,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};

@@ -154,6 +155,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};

@@ -169,6 +171,7 @@
clock-names = "stmmaceth";
tx-fifo-depth = <16384>;
rx-fifo-depth = <16384>;
+ snps,multicast-filter-bins = <256>;
status = "disabled";
};

--
2.17.0

2018-11-05 19:16:59

by Dinh Nguyen

Subject: Re: [PATCH v3] arm64: dts: stratix10: fix multicast filtering

On 11/2/18 2:10 PM, Aaro Koskinen wrote:
> From: Aaro Koskinen <[email protected]>
>
> On Stratix 10, the EMAC has 256 hash buckets for multicast filtering. This
> needs to be specified in DTS, otherwise the stmmac driver defaults to 64
> buckets and initializes the filter incorrectly. As a result, e.g. valid
> IPv6 multicast traffic ends up being dropped.
>
> Fixes: 78cd6a9d8e15 ("arm64: dts: Add base stratix 10 dtsi")
> Signed-off-by: Aaro Koskinen <[email protected]>
> ---
> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>

Applied!

Thanks,
Dinh