2018-11-06 11:35:13

by kernel test robot

[permalink] [raw]
Subject: drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 163c8d54a997153ee1a1e07fcac087492ad85b37
commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 media: platform: Add Cedrus VPU decoder driver
date: 6 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


2018-11-06 12:15:12

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH] media: platform: fix platform_no_drv_owner.cocci warnings

From: kbuild test robot <[email protected]>

drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
CC: Paul Kocialkowski <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 163c8d54a997153ee1a1e07fcac087492ad85b37
commit: 50e761516f2b8c0cdeb31a8c6ca1b4ef98cd13f1 media: platform: Add Cedrus VPU decoder driver

cedrus.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -418,7 +418,6 @@ static struct platform_driver cedrus_dri
.remove = cedrus_remove,
.driver = {
.name = CEDRUS_NAME,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(cedrus_dt_match),
},
};

2018-11-06 12:36:01

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] media: platform: fix platform_no_drv_owner.cocci warnings

On Tue, Nov 06, 2018 at 07:33:19PM +0800, kbuild test robot wrote:
> From: kbuild test robot <[email protected]>
>
> drivers/staging/media/sunxi/cedrus/cedrus.c:421:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> CC: Paul Kocialkowski <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


Attachments:
(No filename) (735.00 B)
signature.asc (235.00 B)
Download all attachments