2018-10-30 22:00:24

by Vasily Averin

Subject: [PATCH v2 05/11] ext4 resize: lost rollback in ext4_resize_fs()

Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7

Signed-off-by: Vasily Averin <[email protected]>
---
fs/ext4/resize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 3df326ee6d50..5fee65afd58b 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -2022,7 +2022,7 @@ int ext4_resize_fs(struct super_block *sb, ext4_fsblk_t n_blocks_count)

err = ext4_alloc_flex_bg_array(sb, n_group + 1);
if (err)
- return err;
+ goto out;

err = ext4_mb_alloc_groupinfo(sb, n_group + 1);
if (err)
--
2.17.1

2018-11-06 21:18:08

by Theodore Ts'o

Subject: Re: [PATCH v2 05/11] ext4 resize: lost rollback in ext4_resize_fs()

On Wed, Oct 31, 2018 at 12:58:09AM +0300, Vasily Averin wrote:
> Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7
>
> Signed-off-by: Vasily Averin <[email protected]>

Thanks, applied. I fixed up the commit description and Fixes/Cc
trailers.

- Ted