2018-11-07 00:53:04

by Fengguang Wu

Subject: [PATCH] net: dsa: bcm_sf2: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>

drivers/net/dsa/bcm_sf2_cfp.c:1168:2-3: Unneeded semicolon
drivers/net/dsa/bcm_sf2_cfp.c:532:2-3: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: ae7a5aff783c ("net: dsa: bcm_sf2: Keep copy of inserted rules")
CC: Florian Fainelli <[email protected]>
Signed-off-by: kbuild test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 5882d526d887e42ead4014d79620e5a8aa741151
commit: ae7a5aff783c79d5ca87867df84b08c43447159b [8/13] net: dsa: bcm_sf2: Keep copy of inserted rules

bcm_sf2_cfp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/net/dsa/bcm_sf2_cfp.c
+++ b/drivers/net/dsa/bcm_sf2_cfp.c
@@ -529,7 +529,7 @@ static struct cfp_rule *bcm_sf2_cfp_rule
list_for_each_entry(rule, &priv->cfp.rules_list, next) {
if (rule->port == port && rule->fs.location == location)
break;
- };
+ }

return rule;
}
@@ -1165,7 +1165,7 @@ int bcm_sf2_cfp_resume(struct dsa_switch
dev_err(ds->dev, "failed to restore rule\n");
return ret;
}
- };
+ }

return ret;
}

2018-11-08 06:15:13

by David Miller

Subject: Re: [PATCH] net: dsa: bcm_sf2: fix semicolon.cocci warnings

From: kbuild test robot <[email protected]>
Date: Wed, 7 Nov 2018 08:50:34 +0800

> From: kbuild test robot <[email protected]>
>
> drivers/net/dsa/bcm_sf2_cfp.c:1168:2-3: Unneeded semicolon
> drivers/net/dsa/bcm_sf2_cfp.c:532:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: ae7a5aff783c ("net: dsa: bcm_sf2: Keep copy of inserted rules")
> CC: Florian Fainelli <[email protected]>
> Signed-off-by: kbuild test robot <[email protected]>

Applied.