2018-11-07 05:18:34

by Zhiqiang Hou

Subject: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

From: Hou Zhiqiang <[email protected]>

The order of parameters is not correct when invoking the outbound
window disable routine.

Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound
windows configured by bootloader").

Cc: [email protected]
Signed-off-by: Hou Zhiqiang <[email protected]>
---
V2:
- Tagged this patch for stable.
- Reworded the commit description.

drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 3724d3ef7008..7aa9a82b7ebd 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
int i;

for (i = 0; i < PCIE_IATU_NUM; i++)
- dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
+ dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
}

static int ls1021_pcie_link_up(struct dw_pcie *pci)
--
2.17.1

2018-11-20 14:42:16

by Lorenzo Pieralisi

Subject: Re: [PATCHv2] PCI/Layerscape: fix wrongly invoking of outbound window disable accessor

On Wed, Nov 07, 2018 at 05:16:49AM +0000, Z.q. Hou wrote:
> From: Hou Zhiqiang <[email protected]>
>
> The order of parameters is not correct when invoking the outbound
> window disable routine.
>
> Fixes: commit 4a2745d760fac ("PCI: layerscape: Disable outbound
> windows configured by bootloader").
>
> Cc: [email protected]
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> V2:
> - Tagged this patch for stable.
> - Reworded the commit description.
>
> drivers/pci/controller/dwc/pci-layerscape.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/controller-fixes for one of the upcoming -rc*.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 3724d3ef7008..7aa9a82b7ebd 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -88,7 +88,7 @@ static void ls_pcie_disable_outbound_atus(struct ls_pcie *pcie)
> int i;
>
> for (i = 0; i < PCIE_IATU_NUM; i++)
> - dw_pcie_disable_atu(pcie->pci, DW_PCIE_REGION_OUTBOUND, i);
> + dw_pcie_disable_atu(pcie->pci, i, DW_PCIE_REGION_OUTBOUND);
> }
>
> static int ls1021_pcie_link_up(struct dw_pcie *pci)
> --
> 2.17.1
>