2018-10-31 19:13:32

by Vasily Averin

Subject: [PATCH 3/7] ext4: lost release of s_journal_flag_rwsem on rollback in ext4_fill_super

Fixes c8585c6fcaf2 ("ext4: fix races between changing inode journal ...") # 4.7

cc: Daeho Jeong <[email protected]>
Signed-off-by: Vasily Averin <[email protected]>
---
fs/ext4/super.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index ed4d36506ec2..0c9e165b4e3f 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4511,6 +4511,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
percpu_counter_destroy(&sbi->s_freeinodes_counter);
percpu_counter_destroy(&sbi->s_dirs_counter);
percpu_counter_destroy(&sbi->s_dirtyclusters_counter);
+ percpu_free_rwsem(&sbi->s_journal_flag_rwsem);
failed_mount5:
ext4_ext_release(sb);
ext4_release_system_zone(sb);
--
2.17.1

2018-11-07 18:03:06

by Theodore Ts'o

Subject: Re: [PATCH 3/7] ext4: lost release of s_journal_flag_rwsem on rollback in ext4_fill_super

On Wed, Oct 31, 2018 at 10:12:35PM +0300, Vasily Averin wrote:
> Fixes c8585c6fcaf2 ("ext4: fix races between changing inode journal ...") # 4.7
>
> cc: Daeho Jeong <[email protected]>
> Signed-off-by: Vasily Averin <[email protected]>

Thanks, applied.

- Ted