2018-11-10 03:40:16

by yangxuan he

[permalink] [raw]
Subject: [PATCH v5 0/3] arm64: dts: meson-gxl: add support for phicomm n1

This patch adds support for the Phicomm N1. This device based on P230 reference design.
The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
And this box doesn't have cvbs, so disable related section in device tree.

Changes since v4:
- include device tree

Changes since v3:
- remove external phy from device tree, will disable EEE in meson-gxl-s905d-p230.dts

Changes since v2:
- remove changes section in commit message
- add commit message for patch of vendor prefix and bindings documentation

Changes since v1:
- rewrite external phy section
- add phicomm vendor prefix
- add phicomm n1 in Documentation/devicetree/bindings/arm/amlogic.txt

He Yangxuan (3):
arm64: dts: meson-gxl: add support for phicomm n1
dt-bindings: Add vendor prefix for PHICOMM Co., Ltd.
dt-bindings: arm: amlogic: Add Phicomm N1

Documentation/devicetree/bindings/arm/amlogic.txt | 1 +
.../devicetree/bindings/vendor-prefixes.txt | 1 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 21 +++++++++++++++++++++
4 files changed, 24 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts

--
2.11.0



2018-11-10 03:40:25

by yangxuan he

[permalink] [raw]
Subject: [PATCH v5 1/3] arm64: dts: meson-gxl: add support for phicomm n1

This patch adds support for the Phicomm N1. This device based on P230 reference design.
And this box doesn't have cvbs, so disable related section in device tree.

Signed-off-by: He Yangxuan <[email protected]>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index c31f29d66..49f3ac5d8 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
new file mode 100644
index 000000000..9a8a8a7e4
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 He Yangxuan
+ */
+
+/dts-v1/;
+
+#include "meson-gxl-s905d-p230.dts"
+
+/ {
+ compatible = "phicomm,n1", "amlogic,s905d", "amlogic,meson-gxl";
+ model = "Phicomm N1";
+
+ cvbs-connector {
+ status = "disabled";
+ };
+};
+
+&cvbs_vdac_port {
+ status = "disabled";
+};
--
2.11.0


2018-11-10 03:40:29

by yangxuan he

[permalink] [raw]
Subject: [PATCH v5 2/3] dt-bindings: Add vendor prefix for PHICOMM Co., Ltd.

PHICOMM Co., Ltd. is a hardware provider headquartered in Shanghai, it's
product includes router and smart devices.

Signed-off-by: He Yangxuan <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4b1a2a8fc..8c413d8cc 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -296,6 +296,7 @@ panasonic Panasonic Corporation
parade Parade Technologies Inc.
pericom Pericom Technology Inc.
pervasive Pervasive Displays, Inc.
+phicomm PHICOMM Co., Ltd.
phytec PHYTEC Messtechnik GmbH
picochip Picochip Ltd
pine64 Pine64
--
2.11.0


2018-11-10 03:40:37

by yangxuan he

[permalink] [raw]
Subject: [PATCH v5 3/3] dt-bindings: arm: amlogic: Add Phicomm N1

Add bindings documentation for the Phicomm N1.

Signed-off-by: He Yangxuan <[email protected]>
---
Documentation/devicetree/bindings/arm/amlogic.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
index 4498292b8..93177f38e 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic.txt
@@ -91,6 +91,7 @@ Board compatible values (alphabetically, grouped by SoC):

- "amlogic,p230" (Meson gxl s905d)
- "amlogic,p231" (Meson gxl s905d)
+ - "phicomm,n1" (Meson gxl s905d)

- "amlogic,p241" (Meson gxl s805x)

--
2.11.0


2018-11-11 22:42:21

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 2/3] dt-bindings: Add vendor prefix for PHICOMM Co., Ltd.

On Sat, 10 Nov 2018 11:39:03 +0800, He Yangxuan wrote:
> PHICOMM Co., Ltd. is a hardware provider headquartered in Shanghai, it's
> product includes router and smart devices.
>
> Signed-off-by: He Yangxuan <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Rob Herring <[email protected]>

2018-11-11 22:42:58

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v5 3/3] dt-bindings: arm: amlogic: Add Phicomm N1

On Sat, 10 Nov 2018 11:39:04 +0800, He Yangxuan wrote:
> Add bindings documentation for the Phicomm N1.
>
> Signed-off-by: He Yangxuan <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/amlogic.txt | 1 +
> 1 file changed, 1 insertion(+)
>

Reviewed-by: Rob Herring <[email protected]>

2018-11-16 08:54:38

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v5 1/3] arm64: dts: meson-gxl: add support for phicomm n1

On 10/11/2018 04:39, He Yangxuan wrote:
> This patch adds support for the Phicomm N1. This device based on P230 reference design.
> And this box doesn't have cvbs, so disable related section in device tree.
>
> Signed-off-by: He Yangxuan <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts | 21 +++++++++++++++++++++
> 2 files changed, 22 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index c31f29d66..49f3ac5d8 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> new file mode 100644
> index 000000000..9a8a8a7e4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2018 He Yangxuan
> + */
> +
> +/dts-v1/;
> +
> +#include "meson-gxl-s905d-p230.dts"
> +
> +/ {
> + compatible = "phicomm,n1", "amlogic,s905d", "amlogic,meson-gxl";
> + model = "Phicomm N1";
> +
> + cvbs-connector {
> + status = "disabled";
> + };
> +};
> +
> +&cvbs_vdac_port {
> + status = "disabled";
> +};
>

Reviewed-by: Neil Armstrong <[email protected]>

2018-11-29 00:13:08

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH v5 0/3] arm64: dts: meson-gxl: add support for phicomm n1

He Yangxuan <[email protected]> writes:

> This patch adds support for the Phicomm N1. This device based on P230 reference design.
> The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
> And this box doesn't have cvbs, so disable related section in device tree.

Thanks for the series.

Queued for v4.21 (branch: v4.21/dt64)

Kevin