2018-11-15 03:17:15

by Icenowy Zheng

[permalink] [raw]

Subject: [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence

---

The SoC-specific compatible should come before the fallback compatible
string when multiple compatible strings are present, but the sequence is
wrong currently on H6 EMAC node (A64 fallback before H6 compatible).

Fix the sequence.

Fixes: c8ced5516d23 ("arm64: allwinner: h6: add EMAC device nodes")
Signed-off-by: Icenowy Zheng <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 45bbb5116446..d1ed451f4d9e 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
@@ -326,8 +326,8 @@
};

emac: ethernet@5020000 {
- compatible = "allwinner,sun50i-a64-emac",
- "allwinner,sun50i-h6-emac";
+ compatible = "allwinner,sun50i-h6-emac",
+ "allwinner,sun50i-a64-emac";
syscon = <&syscon>;
reg = <0x05020000 0x10000>;
interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
--
2.18.1

2018-11-15 15:13:00

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: allwinner: h6: fix EMAC compatible string sequence

---

On Thu, Nov 15, 2018 at 11:15:51AM +0800, Icenowy Zheng wrote:
> The SoC-specific compatible should come before the fallback compatible
> string when multiple compatible strings are present, but the sequence is
> wrong currently on H6 EMAC node (A64 fallback before H6 compatible).
>
> Fix the sequence.
>
> Fixes: c8ced5516d23 ("arm64: allwinner: h6: add EMAC device nodes")
> Signed-off-by: Icenowy Zheng <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

---

Attachments:

(No filename) (555.00 B)
signature.asc (235.00 B)
Download all attachments