2018-11-16 10:48:28

by Brajeswar Ghosh

[permalink] [raw]
Subject: [PATCH] drivers/fsi/fsi-scom.c: Remove duplicate header

Remove linux/cdev.h which is included more than once

Signed-off-by: Brajeswar Ghosh <[email protected]>
---
drivers/fsi/fsi-scom.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index df94021dd9d1..81dc01ac2351 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -20,7 +20,6 @@
#include <linux/fs.h>
#include <linux/uaccess.h>
#include <linux/slab.h>
-#include <linux/cdev.h>
#include <linux/list.h>

#include <uapi/linux/fsi.h>
--
2.17.1



2018-11-24 09:05:04

by Brajeswar Ghosh

[permalink] [raw]
Subject: Re: [PATCH] drivers/fsi/fsi-scom.c: Remove duplicate header

On Fri, Nov 16, 2018 at 4:17 PM Brajeswar Ghosh
<[email protected]> wrote:
>
> Remove linux/cdev.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>

Any comment on this patch?

> ---
> drivers/fsi/fsi-scom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index df94021dd9d1..81dc01ac2351 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -20,7 +20,6 @@
> #include <linux/fs.h>
> #include <linux/uaccess.h>
> #include <linux/slab.h>
> -#include <linux/cdev.h>
> #include <linux/list.h>
>
> #include <uapi/linux/fsi.h>
> --
> 2.17.1
>

2018-11-25 23:10:43

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [PATCH] drivers/fsi/fsi-scom.c: Remove duplicate header

On Sat, 2018-11-24 at 13:51 +0530, Brajeswar Ghosh wrote:
> On Fri, Nov 16, 2018 at 4:17 PM Brajeswar Ghosh
> <[email protected]> wrote:
> > Remove linux/cdev.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <[email protected]>
>
> Any comment on this patch?

Ah sorry, I missed it. Yeah it's fine. I will send it to Greg.

> > ---
> > drivers/fsi/fsi-scom.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> > index df94021dd9d1..81dc01ac2351 100644
> > --- a/drivers/fsi/fsi-scom.c
> > +++ b/drivers/fsi/fsi-scom.c
> > @@ -20,7 +20,6 @@
> > #include <linux/fs.h>
> > #include <linux/uaccess.h>
> > #include <linux/slab.h>
> > -#include <linux/cdev.h>
> > #include <linux/list.h>
> >
> > #include <uapi/linux/fsi.h>
> > --
> > 2.17.1
> >