2018-11-16 10:49:18

by Petr Tesařík

Subject: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()

The driver uses test_facility(), but does not include the
corresponding include file explicitly. The driver currently builds
only thanks to the following include chain:

vfio_ap_drv.c
<linux/module.h>
<linux/elf.h>
<asm/elf.h>
<linux/compat.h>
<asm/uaccess.h>
<asm/facility.h>

Files should not rely on such fragile implicit includes.

Signed-off-by: Petr Tesarik <[email protected]>
---
drivers/s390/crypto/vfio_ap_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 7667b38728f0..31c6c847eaca 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -11,6 +11,7 @@
#include <linux/mod_devicetable.h>
#include <linux/slab.h>
#include <linux/string.h>
+#include <asm/facility.h>
#include "vfio_ap_private.h"

#define VFIO_AP_ROOT_NAME "vfio_ap"
--
2.16.4

2018-11-16 10:59:38

by Cornelia Huck

Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()

On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik <[email protected]> wrote:

> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <[email protected]>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"

Reviewed-by: Cornelia Huck <[email protected]>

2018-11-16 11:50:35

by Christian Borntraeger

Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()

On 11/16/2018 11:47 AM, Petr Tesarik wrote:
> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <[email protected]>

Acked-by: Christian Borntraeger <[email protected]>

> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 7667b38728f0..31c6c847eaca 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"
>

2018-11-16 12:21:36

by Halil Pasic

Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()

On Fri, 16 Nov 2018 11:47:48 +0100
Petr Tesarik <[email protected]> wrote:

> The driver uses test_facility(), but does not include the
> corresponding include file explicitly. The driver currently builds
> only thanks to the following include chain:
>
> vfio_ap_drv.c
> <linux/module.h>
> <linux/elf.h>
> <asm/elf.h>
> <linux/compat.h>
> <asm/uaccess.h>
> <asm/facility.h>
>
> Files should not rely on such fragile implicit includes.
>
> Signed-off-by: Petr Tesarik <[email protected]>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> b/drivers/s390/crypto/vfio_ap_drv.c index 7667b38728f0..31c6c847eaca
> 100644 --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -11,6 +11,7 @@
> #include <linux/mod_devicetable.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <asm/facility.h>
> #include "vfio_ap_private.h"
>
> #define VFIO_AP_ROOT_NAME "vfio_ap"

Applied. Is going to go via Martins S390 tree.

Thanks,
Halil

2018-11-16 12:29:17

by Petr Tesařík

Subject: Re: [PATCH 1/1] s390: vfio-ap: include <asm/facility> for test_facility()

On Fri, 16 Nov 2018 13:20:33 +0100
Halil Pasic <[email protected]> wrote:

> On Fri, 16 Nov 2018 11:47:48 +0100
> Petr Tesarik <[email protected]> wrote:
>
> > The driver uses test_facility(), but does not include the
> > corresponding include file explicitly. The driver currently builds
> > only thanks to the following include chain:
> >
> > vfio_ap_drv.c
> > <linux/module.h>
> > <linux/elf.h>
> > <asm/elf.h>
> > <linux/compat.h>
> > <asm/uaccess.h>
> > <asm/facility.h>
> >
> > Files should not rely on such fragile implicit includes.
> >
> > Signed-off-by: Petr Tesarik <[email protected]>
> > ---
> > drivers/s390/crypto/vfio_ap_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c
> > b/drivers/s390/crypto/vfio_ap_drv.c index 7667b38728f0..31c6c847eaca
> > 100644 --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -11,6 +11,7 @@
> > #include <linux/mod_devicetable.h>
> > #include <linux/slab.h>
> > #include <linux/string.h>
> > +#include <asm/facility.h>
> > #include "vfio_ap_private.h"
> >
> > #define VFIO_AP_ROOT_NAME "vfio_ap"
>
> Applied. Is going to go via Martins S390 tree.

Thank you for the quick turnaround.

Petr Tesarik
SUSE HW Enablement Team