2018-11-05 13:58:54

by Clément Péron

[permalink] [raw]
Subject: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

From: Colin Didier <[email protected]>

The MX6 Audmux differs from MX51.

This patch adds the audmux for i.MX6 family.

Signed-off-by: Colin Didier <[email protected]>
Signed-off-by: Clément Péron <[email protected]>
---
include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
index 15f138bebe16..a1d0741d9ed1 100644
--- a/include/dt-bindings/sound/fsl-imx-audmux.h
+++ b/include/dt-bindings/sound/fsl-imx-audmux.h
@@ -25,6 +25,14 @@
#define MX51_AUDMUX_PORT6 5
#define MX51_AUDMUX_PORT7 6

+#define MX6_AUDMUX_PORT1_SSI1 0
+#define MX6_AUDMUX_PORT2_SSI2 1
+#define MX6_AUDMUX_PORT3 2
+#define MX6_AUDMUX_PORT4 3
+#define MX6_AUDMUX_PORT5 4
+#define MX6_AUDMUX_PORT6 5
+#define MX6_AUDMUX_PORT7_SSI3 6
+
/*
* TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
* can be sourced from Rx/Tx.
--
2.19.1



2018-11-16 03:02:03

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

On Mon, Nov 05, 2018 at 02:58:02PM +0100, Cl?ment P?ron wrote:
> From: Colin Didier <[email protected]>
>
> The MX6 Audmux differs from MX51.
>
> This patch adds the audmux for i.MX6 family.
>
> Signed-off-by: Colin Didier <[email protected]>
> Signed-off-by: Cl?ment P?ron <[email protected]>

I think you should send it to ASoC maintainer and list for applying.

Shawn

> ---
> include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> index 15f138bebe16..a1d0741d9ed1 100644
> --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> @@ -25,6 +25,14 @@
> #define MX51_AUDMUX_PORT6 5
> #define MX51_AUDMUX_PORT7 6
>
> +#define MX6_AUDMUX_PORT1_SSI1 0
> +#define MX6_AUDMUX_PORT2_SSI2 1
> +#define MX6_AUDMUX_PORT3 2
> +#define MX6_AUDMUX_PORT4 3
> +#define MX6_AUDMUX_PORT5 4
> +#define MX6_AUDMUX_PORT6 5
> +#define MX6_AUDMUX_PORT7_SSI3 6
> +
> /*
> * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
> * can be sourced from Rx/Tx.
> --
> 2.19.1
>

2018-11-16 10:28:09

by Clément Péron

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

Hi Shawn,

On Fri, 16 Nov 2018 at 03:59, Shawn Guo <[email protected]> wrote:
>
> On Mon, Nov 05, 2018 at 02:58:02PM +0100, Clément Péron wrote:
> > From: Colin Didier <[email protected]>
> >
> > The MX6 Audmux differs from MX51.
> >
> > This patch adds the audmux for i.MX6 family.
> >
> > Signed-off-by: Colin Didier <[email protected]>
> > Signed-off-by: Clément Péron <[email protected]>
>
> I think you should send it to ASoC maintainer and list for applying.

It's still quite new for me to submit patch, but if this patch should
be sent to ASoC maintainer maybe there is a line missing in the
MAINTAINERS file no ?

SOUND
M: Jaroslav Kysela <[email protected]>
M: Takashi Iwai <[email protected]>
L: [email protected] (moderated for non-subscribers)
W: http://www.alsa-project.org/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
T: git git://git.alsa-project.org/alsa-kernel.git
Q: http://patchwork.kernel.org/project/alsa-devel/list/
S: Maintained
F: Documentation/sound/
+ F: include/dt-bindings/sound/
F: include/sound/
F: include/uapi/sound/
F: sound/

Regards,
Clement

>
> Shawn
>
> > ---
> > include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> > index 15f138bebe16..a1d0741d9ed1 100644
> > --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> > +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> > @@ -25,6 +25,14 @@
> > #define MX51_AUDMUX_PORT6 5
> > #define MX51_AUDMUX_PORT7 6
> >
> > +#define MX6_AUDMUX_PORT1_SSI1 0
> > +#define MX6_AUDMUX_PORT2_SSI2 1
> > +#define MX6_AUDMUX_PORT3 2
> > +#define MX6_AUDMUX_PORT4 3
> > +#define MX6_AUDMUX_PORT5 4
> > +#define MX6_AUDMUX_PORT6 5
> > +#define MX6_AUDMUX_PORT7_SSI3 6
> > +
> > /*
> > * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
> > * can be sourced from Rx/Tx.
> > --
> > 2.19.1
> >

2018-11-16 14:46:34

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

On Fri, Nov 16, 2018 at 11:25:07AM +0100, Cl?ment P?ron wrote:
> Hi Shawn,
>
> On Fri, 16 Nov 2018 at 03:59, Shawn Guo <[email protected]> wrote:
> >
> > On Mon, Nov 05, 2018 at 02:58:02PM +0100, Cl?ment P?ron wrote:
> > > From: Colin Didier <[email protected]>
> > >
> > > The MX6 Audmux differs from MX51.
> > >
> > > This patch adds the audmux for i.MX6 family.
> > >
> > > Signed-off-by: Colin Didier <[email protected]>
> > > Signed-off-by: Cl?ment P?ron <[email protected]>
> >
> > I think you should send it to ASoC maintainer and list for applying.
>
> It's still quite new for me to submit patch, but if this patch should
> be sent to ASoC maintainer maybe there is a line missing in the
> MAINTAINERS file no ?

@Mark, comment?

Shawn

>
> SOUND
> M: Jaroslav Kysela <[email protected]>
> M: Takashi Iwai <[email protected]>
> L: [email protected] (moderated for non-subscribers)
> W: http://www.alsa-project.org/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> T: git git://git.alsa-project.org/alsa-kernel.git
> Q: http://patchwork.kernel.org/project/alsa-devel/list/
> S: Maintained
> F: Documentation/sound/
> + F: include/dt-bindings/sound/
> F: include/sound/
> F: include/uapi/sound/
> F: sound/
>
> Regards,
> Clement
>
> >
> > Shawn
> >
> > > ---
> > > include/dt-bindings/sound/fsl-imx-audmux.h | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/include/dt-bindings/sound/fsl-imx-audmux.h b/include/dt-bindings/sound/fsl-imx-audmux.h
> > > index 15f138bebe16..a1d0741d9ed1 100644
> > > --- a/include/dt-bindings/sound/fsl-imx-audmux.h
> > > +++ b/include/dt-bindings/sound/fsl-imx-audmux.h
> > > @@ -25,6 +25,14 @@
> > > #define MX51_AUDMUX_PORT6 5
> > > #define MX51_AUDMUX_PORT7 6
> > >
> > > +#define MX6_AUDMUX_PORT1_SSI1 0
> > > +#define MX6_AUDMUX_PORT2_SSI2 1
> > > +#define MX6_AUDMUX_PORT3 2
> > > +#define MX6_AUDMUX_PORT4 3
> > > +#define MX6_AUDMUX_PORT5 4
> > > +#define MX6_AUDMUX_PORT6 5
> > > +#define MX6_AUDMUX_PORT7_SSI3 6
> > > +
> > > /*
> > > * TFCSEL/RFCSEL (i.MX27) or TFSEL/TCSEL/RFSEL/RCSEL (i.MX31/51/53/6Q)
> > > * can be sourced from Rx/Tx.
> > > --
> > > 2.19.1
> > >

2018-11-17 03:12:46

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

On Fri, Nov 16, 2018 at 10:45:22PM +0800, Shawn Guo wrote:
> On Fri, Nov 16, 2018 at 11:25:07AM +0100, Cl?ment P?ron wrote:

> > It's still quite new for me to submit patch, but if this patch should
> > be sent to ASoC maintainer maybe there is a line missing in the
> > MAINTAINERS file no ?

> @Mark, comment?

Adding a file pattern for this seems sensible, yes.

Attachments:
(No filename) (375.00 B)
 signature.asc (499.00 B)
 Download all attachments

2018-11-17 12:17:52

by Clément Péron

[permalink] [raw]
Subject: Re: [PATCH] ASoC: imx-audmux: complete dt-bindings for imx6

Hi Mark,

On Sat, 17 Nov 2018 at 04:09, Mark Brown <[email protected]> wrote:
>
> On Fri, Nov 16, 2018 at 10:45:22PM +0800, Shawn Guo wrote:
> > On Fri, Nov 16, 2018 at 11:25:07AM +0100, Clément Péron wrote:
>
> > > It's still quite new for me to submit patch, but if this patch should
> > > be sent to ASoC maintainer maybe there is a line missing in the
> > > MAINTAINERS file no ?
>
> > @Mark, comment?
>
> Adding a file pattern for this seems sensible, yes.
OK,

I will send a v2 for the IMX6 Audmux bindings with ASoC List and Maintainers.

Thanks,
Clement