The setting is removed when running a `savedefconfig` using the
current setting set. It is being applied in preparation to some
patches making changes to this defconfig.
Signed-off-by: Otavio Salvador <[email protected]>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index aa02d18f44d1..0c887a059df3 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -445,4 +445,3 @@ CONFIG_MAGIC_SYSRQ=y
CONFIG_PROVE_LOCKING=y
# CONFIG_DEBUG_BUGVERBOSE is not set
# CONFIG_FTRACE is not set
-# CONFIG_ARM_UNWIND is not set
--
2.19.1
From: Andreas Müller <[email protected]>
This is necessary to support network over bluetooth:
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support
| Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin
Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 0c887a059df3..22ad2d7a1cf2 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -81,6 +81,7 @@ CONFIG_NETFILTER=y
CONFIG_CAN=y
CONFIG_CAN_FLEXCAN=y
CONFIG_BT=y
+CONFIG_BT_BNEP=m
CONFIG_BT_HCIUART=y
CONFIG_BT_HCIUART_LL=y
CONFIG_CFG80211=y
--
2.19.1
From: Andreas Müller <[email protected]>
This is very helpful debugging USB issues.
Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
---
arch/arm/configs/imx_v6_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 22ad2d7a1cf2..d339913845fa 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -305,6 +305,7 @@ CONFIG_SND_SOC_WM8962=y
CONFIG_SND_SIMPLE_CARD=y
CONFIG_HID_MULTITOUCH=y
CONFIG_USB=y
+CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_MXC=y
CONFIG_USB_STORAGE=y
--
2.19.1
Hi Otavio,
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <[email protected]> wrote:
>
> The setting is removed when running a `savedefconfig` using the
> current setting set. It is being applied in preparation to some
"setting set" is a bit confusing.
> patches making changes to this defconfig.
It would be good to mention that CONFIG_ARM_UNWIND is still selected
automatically.
Otherwise it may give the impression that such functionality is being removed.
You could reword the commit log to something like this:
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
still selected by the Kconfig logic.
This is done in preparation to making further changes to this defconfig cleaner.
With the reworded commit log:
Reviewed-by: Fabio Estevam <[email protected]>
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <[email protected]> wrote:
>
> From: Andreas Müller <[email protected]>
>
> This is necessary to support network over bluetooth:
>
> | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: kernel lacks bnep-protocol support
> | Sep 11 15:36:33 imx6qdl-variscite-som bluetoothd[281]: System does not support network plugin
>
> Signed-off-by: Andreas Müller <[email protected]>
> Signed-off-by: Otavio Salvador <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <[email protected]> wrote:
>
> From: Andreas Müller <[email protected]>
>
> This is very helpful debugging USB issues.
>
> Signed-off-by: Andreas Müller <[email protected]>
> Signed-off-by: Otavio Salvador <[email protected]>
Reviewed-by: Fabio Estevam <[email protected]>
Hello Fabio,
On Sun, Nov 25, 2018 at 6:30 PM Fabio Estevam <[email protected]> wrote:
> On Sun, Nov 25, 2018 at 6:18 PM Otavio Salvador <[email protected]> wrote:
> >
> > The setting is removed when running a `savedefconfig` using the
> > current setting set. It is being applied in preparation to some
>
> "setting set" is a bit confusing.
>
> > patches making changes to this defconfig.
>
> It would be good to mention that CONFIG_ARM_UNWIND is still selected
> automatically.
>
> Otherwise it may give the impression that such functionality is being removed.
>
> You could reword the commit log to something like this:
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but it is
> still selected by the Kconfig logic.
> This is done in preparation to making further changes to this defconfig cleaner.
In fact, was removed and now selected.
I changed the commit log as:
ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
selected by the Kconfig logic. This is done in preparation to making
further changes to this defconfig cleaner.
Do you agree?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Hi Otavio,
On Sun, Nov 25, 2018 at 6:49 PM Otavio Salvador
<[email protected]> wrote:
> In fact, was removed and now selected.
Yes, correct. In 4.20-rc1 this option is automatically selected.
> I changed the commit log as:
>
> ARM: imx_v6_v7_defconfig: Remove explicit ARM_UNWIND disable
>
> CONFIG_ARM_UNWIND is removed when running 'savedefconfig', but
> selected by the Kconfig logic. This is done in preparation to making
> further changes to this defconfig cleaner.
>
> Do you agree?
Looks good to me, thanks.