2018-11-26 08:12:46

by Tomas Winkler

Subject: [PATCH] scsi: ufs: add fall through annotation

Add /* fallthrough */ annotation, to eliminate compilation warning:
warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Tomas Winkler <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3807efd895be..b15f5dab0618 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1549,6 +1549,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
* currently running. Hence, fall through to cancel gating
* work and to enable clocks.
*/
+ /* fallthrough */
case CLKS_OFF:
ufshcd_scsi_block_requests(hba);
hba->clk_gating.state = REQ_CLKS_ON;
@@ -1560,6 +1561,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
* fall through to check if we should wait for this
* work to be done or not.
*/
+ /* fallthrough */
case REQ_CLKS_ON:
if (async) {
rc = -EAGAIN;
@@ -4618,6 +4620,7 @@ ufshcd_scsi_cmd_status(struct ufshcd_lrb *lrbp, int scsi_status)
switch (scsi_status) {
case SAM_STAT_CHECK_CONDITION:
ufshcd_copy_sense_data(lrbp);
+ /* fallthrough */
case SAM_STAT_GOOD:
result |= DID_OK << 16 |
COMMAND_COMPLETE << 8 |
--
2.17.2

2018-11-26 15:58:31

by Avri Altman

Subject: RE: [PATCH] scsi: ufs: add fall through annotation

> -----Original Message-----
> From: Tomas Winkler <[email protected]>
> Sent: Monday, November 26, 2018 10:11 AM
> To: James E . J . Bottomley <[email protected]>; Martin K . Petersen
> <[email protected]>; Vinayak Holikatti
> <[email protected]>; Avri Altman <[email protected]>
> Cc: [email protected]; [email protected]; Tomas Winkler
> <[email protected]>
> Subject: [PATCH] scsi: ufs: add fall through annotation
>
> Add /* fallthrough */ annotation, to eliminate compilation warning:
> warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Tomas Winkler <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

2018-11-29 02:45:29

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: add fall through annotation

Tomas,

> Add /* fallthrough */ annotation, to eliminate compilation warning:
> warning: this statement may fall through [-Wimplicit-fallthrough=]

Applied to 4.20/scsi-fixes, thanks!

--
Martin K. Petersen Oracle Linux Engineering