2018-11-22 03:16:34

by Lyude Paul

Subject: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

Noticed the other day the trackpoint felt different on my P50, then
realized it was because rmi4 wasn't loading for this machine
automatically. Suspend/resume, hibernate, and everything else seem to
work perfectly fine on here.

Signed-off-by: Lyude Paul <[email protected]>
---
drivers/input/mouse/synaptics.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5e85f3cca867..c42813d50591 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
"LEN0048", /* X1 Carbon 3 */
"LEN0046", /* X250 */
"LEN004a", /* W541 */
+ "LEN005b", /* P50 */
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
--
2.19.1

2018-11-28 03:48:14

by Peter Hutterer

Subject: Re: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

On Wed, Nov 21, 2018 at 03:16:20PM -0500, Lyude Paul wrote:
> Noticed the other day the trackpoint felt different on my P50, then
> realized it was because rmi4 wasn't loading for this machine
> automatically. Suspend/resume, hibernate, and everything else seem to
> work perfectly fine on here.
>
> Signed-off-by: Lyude Paul <[email protected]>

Acked-by: Peter Hutterer <[email protected]>

Cheers,
Peter

> ---
> drivers/input/mouse/synaptics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 5e85f3cca867..c42813d50591 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0048", /* X1 Carbon 3 */
> "LEN0046", /* X250 */
> "LEN004a", /* W541 */
> + "LEN005b", /* P50 */
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> --
> 2.19.1
>

2018-11-29 11:17:35

by Benjamin Tissoires

Subject: Re: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

On Wed, Nov 28, 2018 at 4:47 AM Peter Hutterer <[email protected]> wrote:
>
> On Wed, Nov 21, 2018 at 03:16:20PM -0500, Lyude Paul wrote:
> > Noticed the other day the trackpoint felt different on my P50, then
> > realized it was because rmi4 wasn't loading for this machine
> > automatically. Suspend/resume, hibernate, and everything else seem to
> > work perfectly fine on here.
> >
> > Signed-off-by: Lyude Paul <[email protected]>
>
> Acked-by: Peter Hutterer <[email protected]>

Acked-by: Benjamin Tissoires <[email protected]>

Cheers,
Benjamin

>
> Cheers,
> Peter
>
> > ---
> > drivers/input/mouse/synaptics.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> > index 5e85f3cca867..c42813d50591 100644
> > --- a/drivers/input/mouse/synaptics.c
> > +++ b/drivers/input/mouse/synaptics.c
> > @@ -170,6 +170,7 @@ static const char * const smbus_pnp_ids[] = {
> > "LEN0048", /* X1 Carbon 3 */
> > "LEN0046", /* X250 */
> > "LEN004a", /* W541 */
> > + "LEN005b", /* P50 */
> > "LEN0071", /* T480 */
> > "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> > "LEN0073", /* X1 Carbon G5 (Elantech) */
> > --
> > 2.19.1
> >