2018-11-28 16:34:21

by Mattias Jacobsson

Subject: [PATCH] x86: boot: add missing va_end to die

Each call to va_start must have a corresponding call to va_end before
the end of the function. Add the missing va_end.

Found with Coccinelle.

Signed-off-by: Mattias Jacobsson <[email protected]>
---
arch/x86/boot/tools/build.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index d4e6cd4577e5..07223fd42d01 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -132,6 +132,7 @@ static void die(const char * str, ...)
va_list args;
va_start(args, str);
vfprintf(stderr, str, args);
+ va_end(args);
fputc('\n', stderr);
exit(1);
}
--
2.19.2

2018-11-28 19:18:22

by tip-bot for Vasyl Gomonovych

Subject: [tip:x86/boot] x86/boot: Add missing va_end() to die()

Commit-ID: 69be4efeb959147ff86f22e35aea9526f9b86715
Gitweb: https://git.kernel.org/tip/69be4efeb959147ff86f22e35aea9526f9b86715
Author: Mattias Jacobsson <[email protected]>
AuthorDate: Wed, 28 Nov 2018 17:16:07 +0100
Committer: Borislav Petkov <[email protected]>
CommitDate: Wed, 28 Nov 2018 20:06:07 +0100

x86/boot: Add missing va_end() to die()

Each call to va_start() must have a corresponding call to va_end()
before the end of the function. Add the missing va_end().

Found with Coccinelle.

Signed-off-by: Mattias Jacobsson <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
arch/x86/boot/tools/build.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/boot/tools/build.c b/arch/x86/boot/tools/build.c
index bf0e82400358..a93d44e58f9c 100644
--- a/arch/x86/boot/tools/build.c
+++ b/arch/x86/boot/tools/build.c
@@ -132,6 +132,7 @@ static void die(const char * str, ...)
va_list args;
va_start(args, str);
vfprintf(stderr, str, args);
+ va_end(args);
fputc('\n', stderr);
exit(1);
}