2018-11-27 14:34:16

by Srikanth Boddepalli

[permalink] [raw]
Subject: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning

Add a missing header otherwise compiler warns about missed prototype:

drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
^~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Srikanth Boddepalli <[email protected]>
---
drivers/xen/xlate_mmu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387..e7df65d 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -36,6 +36,7 @@
#include <asm/xen/hypervisor.h>

#include <xen/xen.h>
+#include <xen/xen-ops.h>
#include <xen/page.h>
#include <xen/interface/xen.h>
#include <xen/interface/memory.h>
--
2.7.4



2018-11-28 16:27:10

by Boris Ostrovsky

[permalink] [raw]
Subject: Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning

On 11/27/18 9:23 AM, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Srikanth Boddepalli <[email protected]>
> ---


Reviewed-by: Boris Ostrovsky <[email protected]>


2018-11-28 18:34:46

by Joey Pabalinas

[permalink] [raw]
Subject: Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning

On Tue, Nov 27, 2018 at 07:53:27PM +0530, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~

Reviewed-by: Joey Pabalinas <[email protected]>

--
Cheers,
Joey Pabalinas

Attachments:
(No filename) (455.00 B)
 signature.asc (849.00 B)
 Download all attachments

2018-11-29 16:56:46

by Jürgen Groß

[permalink] [raw]
Subject: Re: [PATCH] xen: xlate_mmu: add missing header to fix 'W=1' warning

On 27/11/2018 15:23, Srikanth Boddepalli wrote:
> Add a missing header otherwise compiler warns about missed prototype:
>
> drivers/xen/xlate_mmu.c:183:5: warning: no previous prototype for 'xen_xlate_unmap_gfn_range?' [-Wmissing-prototypes]
> int xen_xlate_unmap_gfn_range(struct vm_area_struct *vma,
> ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Srikanth Boddepalli <[email protected]>

Pushed to xen/tip.git for-linus-4.20a


Juergen