2018-12-02 09:19:59

by Baruch Siach

Subject: [PATCH] psi: fix reference to kernel commandline enable

The kernel commandline parameter named in CONFIG_PSI_DEFAULT_DISABLED
help text contradicts the documentation in kernel-parameters.txt, and
the code. Fix that.

Fixes: e0c274472d ("psi: make disabling/enabling easier for vendor kernels")
Signed-off-by: Baruch Siach <[email protected]>
---
init/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index cf5b5a0dcbc2..ed9352513c32 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -515,8 +515,8 @@ config PSI_DEFAULT_DISABLED
depends on PSI
help
If set, pressure stall information tracking will be disabled
- per default but can be enabled through passing psi_enable=1
- on the kernel commandline during boot.
+ per default but can be enabled through passing psi=1 on the
+ kernel commandline during boot.

endmenu # "CPU/Task time and stats accounting"

--
2.19.2

2018-12-03 21:37:04

by Johannes Weiner

Subject: Re: [PATCH] psi: fix reference to kernel commandline enable

On Sun, Dec 02, 2018 at 11:18:50AM +0200, Baruch Siach wrote:
> The kernel commandline parameter named in CONFIG_PSI_DEFAULT_DISABLED
> help text contradicts the documentation in kernel-parameters.txt, and
> the code. Fix that.
>
> Fixes: e0c274472d ("psi: make disabling/enabling easier for vendor kernels")
> Signed-off-by: Baruch Siach <[email protected]>

Doh, thanks Baruch.

Acked-by: Johannes Weiner <[email protected]>

> ---
> init/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index cf5b5a0dcbc2..ed9352513c32 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -515,8 +515,8 @@ config PSI_DEFAULT_DISABLED
> depends on PSI
> help
> If set, pressure stall information tracking will be disabled
> - per default but can be enabled through passing psi_enable=1
> - on the kernel commandline during boot.
> + per default but can be enabled through passing psi=1 on the
> + kernel commandline during boot.
>
> endmenu # "CPU/Task time and stats accounting"