2018-11-30 01:23:12

by Leo Yan

[permalink] [raw]
Subject: [PATCH] coresight: cpu-debug: Support for CA73 CPUs

This patch is to add the AMBA device ID for CA73 CPU, so that CPU debug
module can be initialized successfully when a SoC contain CA73 CPUs.

This patch has been verified on 96boards Hikey960.

Signed-off-by: Leo Yan <[email protected]>
---
drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index 45b2460..e8819d7 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -668,6 +668,10 @@ static const struct amba_id debug_ids[] = {
.id = 0x000bbd08,
.mask = 0x000fffff,
},
+ { /* Debug for Cortex-A73 */
+ .id = 0x000bbd09,
+ .mask = 0x000fffff,
+ },
{ 0, 0 },
};

--
2.7.4



2018-12-03 17:36:01

by Mathieu Poirier

[permalink] [raw]
Subject: Re: [PATCH] coresight: cpu-debug: Support for CA73 CPUs

On Thu, 29 Nov 2018 at 18:22, Leo Yan <[email protected]> wrote:
>
> This patch is to add the AMBA device ID for CA73 CPU, so that CPU debug
> module can be initialized successfully when a SoC contain CA73 CPUs.
>
> This patch has been verified on 96boards Hikey960.
>
> Signed-off-by: Leo Yan <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> index 45b2460..e8819d7 100644
> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> @@ -668,6 +668,10 @@ static const struct amba_id debug_ids[] = {
> .id = 0x000bbd08,
> .mask = 0x000fffff,
> },
> + { /* Debug for Cortex-A73 */
> + .id = 0x000bbd09,
> + .mask = 0x000fffff,
> + },
> { 0, 0 },
> };
>

I have picked this up - thanks.

Mathieu

> --
> 2.7.4
>

2018-12-04 00:33:58

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH] coresight: cpu-debug: Support for CA73 CPUs

On Mon, Dec 03, 2018 at 10:34:07AM -0700, Mathieu Poirier wrote:
> On Thu, 29 Nov 2018 at 18:22, Leo Yan <[email protected]> wrote:
> >
> > This patch is to add the AMBA device ID for CA73 CPU, so that CPU debug
> > module can be initialized successfully when a SoC contain CA73 CPUs.
> >
> > This patch has been verified on 96boards Hikey960.
> >
> > Signed-off-by: Leo Yan <[email protected]>
> > ---
> > drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > index 45b2460..e8819d7 100644
> > --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
> > @@ -668,6 +668,10 @@ static const struct amba_id debug_ids[] = {
> > .id = 0x000bbd08,
> > .mask = 0x000fffff,
> > },
> > + { /* Debug for Cortex-A73 */
> > + .id = 0x000bbd09,
> > + .mask = 0x000fffff,
> > + },
> > { 0, 0 },
> > };
> >
>
> I have picked this up - thanks.

Thanks, Mathieu.