2018-12-06 10:27:38

by David Abdurachmanov

Subject: [PATCH] riscv: remove unused variable in ftrace

Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
Fedora 30/RISCV.

[..]
BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
BUILDSTDERR: int err;
BUILDSTDERR: ^~~
[..]

Signed-off-by: David Abdurachmanov <[email protected]>
---
arch/riscv/kernel/ftrace.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/ftrace.c b/arch/riscv/kernel/ftrace.c
index c433f6d3dd64..a840b7d074f7 100644
--- a/arch/riscv/kernel/ftrace.c
+++ b/arch/riscv/kernel/ftrace.c
@@ -132,7 +132,6 @@ void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr,
{
unsigned long return_hooker = (unsigned long)&return_to_handler;
unsigned long old;
- int err;

if (unlikely(atomic_read(&current->tracing_graph_pause)))
return;
--
2.19.2

2018-12-06 19:22:42

by Olof Johansson

Subject: Re: [PATCH] riscv: remove unused variable in ftrace

On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
<[email protected]> wrote:
>
> Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> Fedora 30/RISCV.
>
> [..]
> BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> BUILDSTDERR: int err;
> BUILDSTDERR: ^~~
> [..]
>
> Signed-off-by: David Abdurachmanov <[email protected]>

Please add a:
Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
function_graph_enter()")
Reviewed-by: Olof Johansson <[email protected]>

2018-12-07 01:09:21

by Steven Rostedt

Subject: Re: [PATCH] riscv: remove unused variable in ftrace

On Thu, 6 Dec 2018 11:20:31 -0800
Olof Johansson <[email protected]> wrote:

> On Thu, Dec 6, 2018 at 2:26 AM David Abdurachmanov
> <[email protected]> wrote:
> >
> > Noticed while building kernel-4.20.0-0.rc5.git2.1.fc30 for
> > Fedora 30/RISCV.
> >
> > [..]
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c: In function 'prepare_ftrace_return':
> > BUILDSTDERR: arch/riscv/kernel/ftrace.c:135:6: warning: unused variable 'err' [-Wunused-variable]
> > BUILDSTDERR: int err;
> > BUILDSTDERR: ^~~

Bah. I could have sworn I checked for all the error messages when I did
my cross-compiling of the architectures. I fixed this issue in other
places, not sure how I missed riscv.

Thanks for fixing it.

Acked-by: Steven Rostedt (VMware) <[email protected]>

-- Steve


> > [..]
> >
> > Signed-off-by: David Abdurachmanov <[email protected]>
>
> Please add a:
> Fixes: e949b6db51dc1 ("riscv/function_graph: Simplify with
> function_graph_enter()")
> Reviewed-by: Olof Johansson <[email protected]>