2018-12-07 15:48:36

by Kirill Tkhai

Subject: [PATCH] mm: Remove useless check in pagecache_get_page()

page always is not NULL, so we may remove this useless check.

Signed-off-by: Kirill Tkhai <[email protected]>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index b1165a311a1f..5da9ce090898 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1601,7 +1601,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset,
VM_BUG_ON_PAGE(page->index != offset, page);
}

- if (page && (fgp_flags & FGP_ACCESSED))
+ if (fgp_flags & FGP_ACCESSED)
mark_page_accessed(page);

no_page:

2018-12-07 17:06:09

by Cyrill Gorcunov

Subject: Re: [PATCH] mm: Remove useless check in pagecache_get_page()

On Fri, Dec 07, 2018 at 06:46:24PM +0300, Kirill Tkhai wrote:
> page always is not NULL, so we may remove this useless check.
>
> Signed-off-by: Kirill Tkhai <[email protected]>
Acked-by: Cyrill Gorcunov <[email protected]>