2018-12-10 16:05:51

by Felix Brack

[permalink] [raw]
Subject: [PATCH] ARM: dts: am33xx: Remove unnecessary properties

Remove the unnecessary properties #address-cells and #size-cells
of node pinmux as there are no child-nodes with property reg.

Signed-off-by: Felix Brack <[email protected]>
---
arch/arm/boot/dts/am33xx.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index d3dd6a16e70a..d640cdffe355 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -208,8 +208,6 @@
am33xx_pinmux: pinmux@800 {
compatible = "pinctrl-single";
reg = <0x800 0x238>;
- #address-cells = <1>;
- #size-cells = <0>;
#pinctrl-cells = <1>;
pinctrl-single,register-width = <32>;
pinctrl-single,function-mask = <0x7f>;
--
2.17.1



2018-12-11 16:45:05

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am33xx: Remove unnecessary properties

* Tony Lindgren <[email protected]> [181211 16:36]:
> * Felix Brack <[email protected]> [181210 05:25]:
> > Remove the unnecessary properties #address-cells and #size-cells
> > of node pinmux as there are no child-nodes with property reg.
>
> Applying into omap-for-v4.21/dt thanks.

Actually this currently conflicts with the pending
am33xx l4 ti-sysc changes, so let's wait on this
one to avoid causing merge conflicts between
branches.

So dropping for now.

Regards,

Tony

2018-12-11 17:20:09

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am33xx: Remove unnecessary properties

* Felix Brack <[email protected]> [181210 05:25]:
> Remove the unnecessary properties #address-cells and #size-cells
> of node pinmux as there are no child-nodes with property reg.

Applying into omap-for-v4.21/dt thanks.

Tony

2018-12-14 15:14:06

by Felix Brack

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am33xx: Remove unnecessary properties

Hi Tony,

On 11.12.2018 17:43, Tony Lindgren wrote:
> * Tony Lindgren <[email protected]> [181211 16:36]:
>> * Felix Brack <[email protected]> [181210 05:25]:
>>> Remove the unnecessary properties #address-cells and #size-cells
>>> of node pinmux as there are no child-nodes with property reg.
>>
>> Applying into omap-for-v4.21/dt thanks.
>
> Actually this currently conflicts with the pending
> am33xx l4 ti-sysc changes, so let's wait on this
> one to avoid causing merge conflicts between
> branches.
>
Okay, I see. The changes introduced by my patch would then affect the
new file am33xx-l4.dtsi instead of am33xx.dtsi

> So dropping for now.
>
Will you "apply" my patch once the am33xx l4 ti-sysc changes are applied
or do you expect me to send V2 patch (to be applied to the new
am33xx-l4.dtsi) ?

regards, Felix

2018-12-14 15:20:59

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: am33xx: Remove unnecessary properties

* Felix Brack <[email protected]> [181214 15:12]:
> Hi Tony,
>
> On 11.12.2018 17:43, Tony Lindgren wrote:
> > * Tony Lindgren <[email protected]> [181211 16:36]:
> >> * Felix Brack <[email protected]> [181210 05:25]:
> >>> Remove the unnecessary properties #address-cells and #size-cells
> >>> of node pinmux as there are no child-nodes with property reg.
> >>
> >> Applying into omap-for-v4.21/dt thanks.
> >
> > Actually this currently conflicts with the pending
> > am33xx l4 ti-sysc changes, so let's wait on this
> > one to avoid causing merge conflicts between
> > branches.
> >
> Okay, I see. The changes introduced by my patch would then affect the
> new file am33xx-l4.dtsi instead of am33xx.dtsi

Yup, and I wanted to keep the am33xx-l4.dtsi in a separate
branch from the rest of the dts changes.

> > So dropping for now.
> >
> Will you "apply" my patch once the am33xx l4 ti-sysc changes are applied
> or do you expect me to send V2 patch (to be applied to the new
> am33xx-l4.dtsi) ?

I'd prefer you to send an updated version against
Linux next as the am33xx-l4.dtsi changes have been
in next for a while now. It is unlikely at this point
that they would not get merged, but I'd rather wait
a bit before applying to avoid mixing the two otherwise
independent branches :)

Regards,

Tony