2018-12-12 21:56:06

by Tao Ren

Subject: [PATCH] gpio: aspeed: remove duplicated statement

Remove duplicated assignment statement from aspeed_gpio_probe() function.

Signed-off-by: Tao Ren <[email protected]>
---
drivers/gpio/gpio-aspeed.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
index 2342e154029b..854bce4fb9e7 100644
--- a/drivers/gpio/gpio-aspeed.c
+++ b/drivers/gpio/gpio-aspeed.c
@@ -1185,7 +1185,6 @@ static int __init aspeed_gpio_probe(struct platform_device *pdev)

gpio->chip.parent = &pdev->dev;
gpio->chip.ngpio = gpio->config->nr_gpios;
- gpio->chip.parent = &pdev->dev;
gpio->chip.direction_input = aspeed_gpio_dir_in;
gpio->chip.direction_output = aspeed_gpio_dir_out;
gpio->chip.get_direction = aspeed_gpio_get_direction;
--
2.17.1

2018-12-13 01:11:08

by Joel Stanley

Subject: Re: [PATCH] gpio: aspeed: remove duplicated statement

On Thu, 13 Dec 2018 at 08:24, Tao Ren <[email protected]> wrote:
>
> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <[email protected]>

Acked-by: Joel Stanley <[email protected]>

Thanks Tao!

2018-12-21 18:52:41

by Linus Walleij

Subject: Re: [PATCH] gpio: aspeed: remove duplicated statement

On Wed, Dec 12, 2018 at 10:53 PM Tao Ren <[email protected]> wrote:

> Remove duplicated assignment statement from aspeed_gpio_probe() function.
>
> Signed-off-by: Tao Ren <[email protected]>

Patch applied with Joel's ACK.

Yours,
Linus Walleij